You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "abnobdoss (via GitHub)" <gi...@apache.org> on 2026/06/23 00:55:16 UTC
[PR] ci: run lint-and-test on the real os matrix [iceberg-go]
abnobdoss opened a new pull request, #1264:
URL: https://github.com/apache/iceberg-go/pull/1264
Closes #1261
## What
Set `runs-on: ${{ matrix.os }}` so the matrix actually selects runners, and turn on macOS alongside Linux. `windows-latest` stays commented out until the path issues in #1262 are sorted. Also add `*.go text eol=lf` to `.gitattributes` so gofmt passes when Go files are checked out on a non-Linux runner.
## Why
`runs-on:` was hardcoded to `ubuntu-latest` while `name:` used `${{ matrix.os }}`, so the `os` axis had no effect and every job ran on Linux. macOS was listed but never actually tested. Making the matrix real gets macOS covered now. Windows needs filesystem-path fixes first (#1262), so it stays off for the moment. The `.gitattributes` rule keeps the gofmt linter from failing if a runner checks out Go sources with CRLF.
## Validation
Tested in a fork: the macOS cells ran lint, tests, and the race job green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci: run lint-and-test on the real os matrix [iceberg-go]
Posted by "abnobdoss (via GitHub)" <gi...@apache.org>.
abnobdoss commented on PR #1264:
URL: https://github.com/apache/iceberg-go/pull/1264#issuecomment-4783965701
Thank you for the review! I've rebased and added the EOF newline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci: run lint-and-test on the real os matrix [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #1264:
URL: https://github.com/apache/iceberg-go/pull/1264#discussion_r3461734722
##########
.gitattributes:
##########
@@ -20,4 +20,8 @@
# uses an industry standard as opposed to possibly hard to read
# shell scripts with many flags. Unfortunately, directories themselves
# won't recursively ignore, so we need the top level directories
-# as well as their files.
\ No newline at end of file
+# as well as their files.
+
+# Force LF for Go sources so gofmt passes when checked out on Windows
+# (Windows runners would otherwise convert LF to CRLF and fail the gofmt linter).
+*.go text eol=lf
Review Comment:
add a newline to the end of the file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci: run lint-and-test on the real os matrix [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1264:
URL: https://github.com/apache/iceberg-go/pull/1264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org