You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ya-nsh (via GitHub)" <gi...@apache.org> on 2026/05/16 06:54:52 UTC
[PR] fix(treemap): remove gaps between chart nodes [superset]
ya-nsh opened a new pull request, #40181:
URL: https://github.com/apache/superset/pull/40181
## Summary
- Remove Treemap node border/gap spacing so tiles render flush again
- Add a transformProps regression test covering the root and child node item styles
## Testing
- `npm run test -- plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts`
- `npm run lint -- plugins/plugin-chart-echarts/src/Treemap/constants.ts plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts`
- `uvx pre-commit run --files superset-frontend/plugins/plugin-chart-echarts/src/Treemap/constants.ts superset-frontend/plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts`
Partial fix for #36807: this addresses the visible gap between Treemap nodes. The sequential color behavior described in the issue appears to be separate and is left unchanged here to keep this PR focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "ya-nsh (via GitHub)" <gi...@apache.org>.
ya-nsh commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4467738440
Addressed the latest Bito review note in `1ce1060`: the filtered-state regression test now asserts the dimmed-state properties (`colorAlpha: OpacityEnum.SemiTransparent` and label override) in addition to the zero border/gap values. I also resolved both bot review threads.
Validation:
- `npm run test -- plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts`
- `npm run lint -- plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts`
- `uvx pre-commit run --files superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts superset-frontend/plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4466086478
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4467419142
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "ya-nsh (via GitHub)" <gi...@apache.org>.
ya-nsh commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4528645209
Thanks, added a before and after visual section to the PR description with the gap/seam case and the flush rendering after this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4522788415
Thanks for your contribution to the project. Could you please add before and after screenshots to the pull request description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #40181:
URL: https://github.com/apache/superset/pull/40181#discussion_r3253113331
##########
superset-frontend/plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts:
##########
@@ -74,4 +74,42 @@ describe('Treemap transformProps', () => {
}),
);
});
+
+ test('should not render gaps between treemap nodes when filtered', () => {
+ const filteredChartProps = new ChartProps({
+ ...chartProps,
+ filterState: { selectedValues: ['Sylvester,bar1'] },
+ });
+
+ expect(
+ transformProps(filteredChartProps as EchartsTreemapChartProps),
+ ).toEqual(
+ expect.objectContaining({
+ echartOptions: expect.objectContaining({
+ series: [
+ expect.objectContaining({
+ data: expect.arrayContaining([
+ expect.objectContaining({
+ children: expect.arrayContaining([
+ expect.objectContaining({
+ name: 'Arnold',
+ children: expect.arrayContaining([
+ expect.objectContaining({
+ name: 'bar2',
+ itemStyle: expect.objectContaining({
+ borderWidth: 0,
+ gapWidth: 0,
+ }),
+ }),
+ ]),
+ }),
+ ]),
+ }),
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete assertion for dimmed state</b></div>
<div id="fix">
Test at line 78-107 asserts on `borderWidth: 0` and `gapWidth: 0` for Arnold/bar2, but these are identical for both dimmed and non-dimmed states (both use BORDER_WIDTH=0 and GAP_WIDTH=0). Per `transformProps.ts:207-214`, nodes NOT in `selectedValues` are dimmed via `colorAlpha: OpacityEnum.SemiTransparent` (0.3) and `label: {...}`. The test does not verify these distinguishing properties, so it only passes coincidentally because default border/gap values happen to be 0.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- superset-frontend/plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts (lines 78-113) ---
78: test('should not render gaps between treemap nodes when filtered', () => {
79: const filteredChartProps = new ChartProps({
80: ...chartProps,
81: filterState: { selectedValues: ['Sylvester,bar1'] },
82: });
84: expect(
85: transformProps(filteredChartProps as EchartsTreemapChartProps),
86: ).toEqual(
87: expect.objectContaining({
88: echartOptions: expect.objectContaining({
89: series: [
90: expect.objectContaining({
91: data: expect.arrayContaining([
92: expect.objectContaining({
93: children: expect.arrayContaining([
94: expect.objectContaining({
95: name: 'Arnold',
96: children: expect.arrayContaining([
97: expect.objectContaining({
98: name: 'bar2',
99: itemStyle: expect.objectContaining({
100: borderWidth: 0,
101: gapWidth: 0,
102: colorAlpha: 0.3,
103: }),
104: label: expect.objectContaining({}),
105: }),
106: ]),
107: }),
108: ]),
109: }),
110: ]),
111: }),
112: ],
113: }),
114: ),
115: );
116: });
```
</div>
</details>
</div>
<small><i>Code Review Run #60bd9f</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #40181:
URL: https://github.com/apache/superset/pull/40181#discussion_r3252402188
##########
superset-frontend/plugins/plugin-chart-echarts/src/Treemap/constants.ts:
##########
@@ -21,8 +21,8 @@ import { TreePathInfo } from '../types';
export const COLOR_SATURATION = [0.7, 0.4];
export const LABEL_FONTSIZE = 11;
-export const BORDER_WIDTH = 2;
-export const GAP_WIDTH = 2;
+export const BORDER_WIDTH = 0;
+export const GAP_WIDTH = 0;
Review Comment:
**Suggestion:** Setting global treemap border/gap constants to zero only fixes the default node style, but filtered (non-selected) leaf nodes still get a hardcoded `borderWidth: 2` in `transformProps`, so gaps reappear during cross-filter interactions. Apply the same zero-gap policy in that filtered-node branch as well (and set `gapWidth` there) to keep tiles flush in all states. [incomplete implementation]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Treemap cross-filtered leaves show gaps despite zero-gap constants.
- ⚠️ Visual inconsistency between default and filtered treemap node styles.
- ⚠️ Undercuts PR goal of removing treemap node spacing.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Render a Treemap chart using the ECharts Treemap plugin, which wires `transformProps`
from
`superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts:107-243` via
the plugin registration in
`superset-frontend/plugins/plugin-chart-echarts/src/Treemap/index.ts:34-82`.
2. Observe that for the root node and all normal child nodes, `transformProps` constructs
`itemStyle` with `borderWidth: BORDER_WIDTH` and `gapWidth: GAP_WIDTH` (see
`transformProps.ts:187-196` for leaf defaults and `transformProps.ts:228-237` for the root
node), and `BORDER_WIDTH`/`GAP_WIDTH` are both `0` as defined in
`superset-frontend/plugins/plugin-chart-echarts/src/Treemap/constants.ts:22-25`, so tiles
render flush with no gaps in the default state.
3. Trigger a cross-filtered or externally-filtered state so that
`filterState.selectedValues` is populated and does not include at least one leaf's
`joinedName` key (built at `transformProps.ts:186-205`); for such non-selected leaves,
execution enters the filtered branch at `transformProps.ts:207-218`, where `itemStyle` is
overridden to `{ colorAlpha: OpacityEnum.SemiTransparent, color: theme.colorText,
borderColor: theme.colorBgBase, borderWidth: 2 }` without applying `gapWidth`.
4. Inspect the rendered treemap (or log the produced ECharts option) and note that
filtered, non-selected leaf nodes now have `borderWidth: 2` while other nodes use
`borderWidth: 0` and `gapWidth: 0`, causing visible gaps/borders to reappear around those
filtered tiles despite the global zero-gap constants in `constants.ts:24-25`, confirming
that the zero-gap policy is not applied consistently across all rendering paths.
```
</details>
[Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20superset-frontend%2Fplugins%2Fplugin-chart-echarts%2Fsrc%2FTreemap%2Fconstants.ts%0A%2A%2ALine%3A%2A%2A%2024%3A25%0A%2A%2AComment%3A%2A%2A%0A%09%2AIncomplete%20Implementation%3A%20Setting%20global%20treemap%20border%2Fgap%20constants%20to%20zero%20only%20fixes%20the%20default%20node%20style%2C%20but%20filtered%20%28non-selected%29%20leaf%20nodes%20still%20get%20a%20hardcoded%20%60borderWidth%3A%202%60%20in%20%60transformProps%60%2C%20so%20gaps%20reappear%20during%20cross-filter%20interactions.%20Apply%20the%20same%20zero-gap%20policy%20in%20that%20filtered-node%20branch%20as%20well%20%28and%20set%20%60gapWidth%60%20there%29%20to%20keep%20tiles%20flush%20in%20all%20states.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20imp
lement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20superset-frontend%2Fplugins%2Fplugin-chart-echarts%2Fsrc%2FTreemap%2Fconstants.ts%0A%2A%2ALine%3A%2A%2A%2024%3A25%0A%2A%2AComment%3A%2A%2A%0A%09%2AIncomplete%20Implementation%3A%20Setting%20global%20treemap%20border%2Fgap%20constants%20to%20zero%20only%20fixes%20the%20default%20node%20style%2C%20but%20filtered%20%28non-selected%29%20leaf%20nodes%20still%20get%20a%20hardcoded%20%60borderWidth%3A%202%60%20in%20%60transformProps%60%2C%20so%20
gaps%20reappear%20during%20cross-filter%20interactions.%20Apply%20the%20same%20zero-gap%20policy%20in%20that%20filtered-node%20branch%20as%20well%20%28and%20set%20%60gapWidth%60%20there%29%20to%20keep%20tiles%20flush%20in%20all%20states.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-echarts/src/Treemap/constants.ts
**Line:** 24:25
**Comment:**
*Incomplete Implementation: Setting global treemap border/gap constants to zero only fixes the default node style, but filtered (non-selected) leaf nodes still get a hardcoded `borderWidth: 2` in `transformProps`, so gaps reappear during cross-filter interactions. Apply the same zero-gap policy in that filtered-node branch as well (and set `gapWidth` there) to keep tiles flush in all states.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40181&comment_hash=199e23c70d79bcf85ebc522fc536e38f1c1bbb75f17c3dfc8a137f0a6a83dedc&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40181&comment_hash=199e23c70d79bcf85ebc522fc536e38f1c1bbb75f17c3dfc8a137f0a6a83dedc&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "ya-nsh (via GitHub)" <gi...@apache.org>.
ya-nsh commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4501808943
Friendly review ping: this PR is ready for maintainer review when you get a chance. Known status: 4 check(s) currently failing; I can follow up if review points to needed changes.
Happy to adjust quickly if you want a different shape or narrower scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "ya-nsh (via GitHub)" <gi...@apache.org>.
ya-nsh commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4466971076
Addressed the review note in c0d03ab: filtered, non-selected treemap leaves now use the same zero border/gap constants as default nodes, and the regression test covers the filtered state.\n\nValidation:\n- npm run test -- plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts\n- npm run lint -- plugins/plugin-chart-echarts/src/Treemap/transformProps.ts plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts\n- uvx pre-commit run --files superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts superset-frontend/plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "ya-nsh (via GitHub)" <gi...@apache.org>.
ya-nsh commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4467738024
Addressed the latest Bito review note in 1ce1060: the filtered-state regression test now asserts the dimmed-state properties ( and label override) in addition to the zero border/gap values. I also resolved both bot review threads.\n\nValidation:\n- npm run test -- plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts\n- npm run lint -- plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts\n- uvx pre-commit run --files superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts superset-frontend/plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4481038775
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40181?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.16%. Comparing base ([`8d2b655`](https://app.codecov.io/gh/apache/superset/commit/8d2b655c22d8e678b25f8be1cea8602523bd6f90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ce1060`](https://app.codecov.io/gh/apache/superset/commit/1ce1060adfd2dca46d57946b5a9bdee649beb9b8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 45 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40181 +/- ##
=======================================
Coverage 64.16% 64.16%
=======================================
Files 2591 2591
Lines 138162 138162
Branches 32048 32048
=======================================
+ Hits 88647 88650 +3
+ Misses 47986 47983 -3
Partials 1529 1529
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/40181/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/40181/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.01% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40181?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4468185676
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40181:
URL: https://github.com/apache/superset/pull/40181#issuecomment-4466095786
<!-- Bito Reply -->
The PR comment file contains only 1 row of actual content (header row plus 1 data row). The suggestion about treemap border/gap constants appears to be the only comment in this PR. I'll analyze it and provide a code fix.
**transformProps.ts**
```
207: // Filtered leaf node style override
208: itemStyle: {
209: colorAlpha: OpacityEnum.SemiTransparent,
210: color: theme.colorText,
211: borderColor: theme.colorBgBase,
212: borderWidth: 2, // Hardcoded value causing gaps
213: },
```
**constants.ts**
```
22: export const BORDER_WIDTH = 0;
23: export const GAP_WIDTH = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(treemap): remove gaps between chart nodes [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 merged PR #40181:
URL: https://github.com/apache/superset/pull/40181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org