Apacheds package collision (OSGi)

[Emmanuel Lecharny <el...@gmail.com>]

Hi guys,

I have grepped the apacheds packages and classes. Here are the package 
that collide :
/org/apache/directory/server/ ./http-directory-bridge/src/main/java
/org/apache/directory/server/ ./service/src/main/java
/org/apache/directory/server/ ./service/src/main/java
/org/apache/directory/server/ ./wrapper/src/main/java

/org/apache/directory/server/config/ ./server-config/src/main/java
/org/apache/directory/server/config/ ./service-builder/src/main/java

/org/apache/directory/server/core/ ./core-api/src/main/java
/org/apache/directory/server/core/ ./core/src/main/java

/org/apache/directory/server/core/changelog/ ./core-api/src/main/java
/org/apache/directory/server/core/changelog/ ./core/src/main/java

/org/apache/directory/server/core/event/ ./core-api/src/main/java
/org/apache/directory/server/core/event/ ./core/src/main/java

/org/apache/directory/server/core/integ/ ./core-integ/src/main/java
/org/apache/directory/server/core/integ/ ./test-framework/src/main/java

/org/apache/directory/server/core/journal/ ./core-api/src/main/java
/org/apache/directory/server/core/journal/ ./core/src/main/java

/org/apache/directory/server/core/partition/ ./core-api/src/main/java
/org/apache/directory/server/core/partition/ ./core/src/main/java

/org/apache/directory/server/core/replication/ ./core-api/src/main/java
/org/apache/directory/server/core/replication/ ./core/src/main/java

/org/apache/directory/server/core/schema/ ./core-api/src/main/java
/org/apache/directory/server/core/schema/ ./core/src/main/java

/org/apache/directory/server/kerberos/protocol/ 
./kerberos-codec/src/main/java
/org/apache/directory/server/kerberos/protocol/ 
./protocol-kerberos/src/main/java

/org/apache/directory/server/ldap/handlers/extended/ 
./protocol-ldap/src/main/java
/org/apache/directory/server/ldap/handlers/extended/ 
./server-tools/src/main/java


-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: Apacheds package collision (OSGi)

[Alex Karasulu <ak...@apache.org>]

On Thu, Apr 28, 2011 at 8:35 PM, Emmanuel Lecharny <el...@gmail.com>wrote:

> On 4/27/11 1:46 PM, Emmanuel Lécharny wrote:
>
>> package /org/apache/directory/server/core/ is declared in modules core-api
>> and core
>> package /org/apache/directory/server/core/changelog/ is declared in
>> modules core-api and core
>> package /org/apache/directory/server/core/event/ is declared in modules
>> core-api and core
>> package /org/apache/directory/server/core/journal/ is declared in modules
>> core-api and core
>> package /org/apache/directory/server/core/partition/ is declared in
>> modules core-api and core
>> package /org/apache/directory/server/core/replication/ is declared in
>> modules core-api and core
>> package /org/apache/directory/server/core/schema/ is declared in modules
>> core-api and core
>>
>> package /org/apache/directory/server/ is declared in modules
>> http-directory-bridge, service, wrapper
>> package /org/apache/directory/server/config/ is declared in modules
>> server-config and service-builder
>> package /org/apache/directory/server/core/integ/ is declared in modules
>> core-integ and test-framework
>> package /org/apache/directory/server/kerberos/protocol/ is declared in
>> modules kerberos-codec and protocol-kerberos
>> package /org/apache/directory/server/ldap/handlers/extended/ is declared
>> in modules protocol-ldap and server-tools
>>
>> We just have 12 duplications, most of them being between core and core-api
>> (which makes sense. Renaming the core packages by adding an impl can solve
>> this issue.
>>
>
> Question : is it enough to rename the core module package to
> /org/apache/directory/server/core/impl/ ?


Should work.

Alex

Re: Apacheds package collision (OSGi)

[Emmanuel Lecharny <el...@gmail.com>]

On 4/27/11 1:46 PM, Emmanuel Lécharny wrote:
> package /org/apache/directory/server/core/ is declared in modules 
> core-api and core
> package /org/apache/directory/server/core/changelog/ is declared in 
> modules core-api and core
> package /org/apache/directory/server/core/event/ is declared in 
> modules core-api and core
> package /org/apache/directory/server/core/journal/ is declared in 
> modules core-api and core
> package /org/apache/directory/server/core/partition/ is declared in 
> modules core-api and core
> package /org/apache/directory/server/core/replication/ is declared in 
> modules core-api and core
> package /org/apache/directory/server/core/schema/ is declared in 
> modules core-api and core
>
> package /org/apache/directory/server/ is declared in modules 
> http-directory-bridge, service, wrapper
> package /org/apache/directory/server/config/ is declared in modules 
> server-config and service-builder
> package /org/apache/directory/server/core/integ/ is declared in 
> modules core-integ and test-framework
> package /org/apache/directory/server/kerberos/protocol/ is declared in 
> modules kerberos-codec and protocol-kerberos
> package /org/apache/directory/server/ldap/handlers/extended/ is 
> declared in modules protocol-ldap and server-tools
>
> We just have 12 duplications, most of them being between core and 
> core-api (which makes sense. Renaming the core packages by adding an 
> impl can solve this issue.

Question : is it enough to rename the core module package to 
/org/apache/directory/server/core/impl/ ?

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: Apacheds package collision (OSGi)

[Emmanuel Lécharny <el...@apache.org>]

On 4/27/11 12:54 PM, Alex Karasulu wrote:
> Sorry I don't get it, can you list which two artifacts contain the same
> package instead of this listing?

Sorry, I inverted the listing.

The packages come first, then for each duplication, you have the modules 
in which they are declared.

Let me reformat that :

package /org/apache/directory/server/core/ is declared in modules 
core-api and core
package /org/apache/directory/server/core/changelog/ is declared in 
modules core-api and core
package /org/apache/directory/server/core/event/ is declared in modules 
core-api and core
package /org/apache/directory/server/core/journal/ is declared in 
modules core-api and core
package /org/apache/directory/server/core/partition/ is declared in 
modules core-api and core
package /org/apache/directory/server/core/replication/ is declared in 
modules core-api and core
package /org/apache/directory/server/core/schema/ is declared in modules 
core-api and core

package /org/apache/directory/server/ is declared in modules 
http-directory-bridge, service, wrapper
package /org/apache/directory/server/config/ is declared in modules 
server-config and service-builder
package /org/apache/directory/server/core/integ/ is declared in modules 
core-integ and test-framework
package /org/apache/directory/server/kerberos/protocol/ is declared in 
modules kerberos-codec and protocol-kerberos
package /org/apache/directory/server/ldap/handlers/extended/ is declared 
in modules protocol-ldap and server-tools

We just have 12 duplications, most of them being between core and 
core-api (which makes sense. Renaming the core packages by adding an 
impl can solve this issue.


--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com





-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: Apacheds package collision (OSGi)

[Alex Karasulu <ak...@apache.org>]

Posting to the ML - seems we slipped and privately emailed this stuff. More
below ..

On Wed, Apr 27, 2011 at 2:46 PM, Emmanuel Lécharny <el...@apache.org>wrote:

> On 4/27/11 12:54 PM, Alex Karasulu wrote:
>
>> Sorry I don't get it, can you list which two artifacts contain the same
>> package instead of this listing?
>>
>
> Sorry, I inverted the listing.
>
>
No worries thanks for getting back to me.


> The packages come first, then for each duplication, you have the modules in
> which they are declared.
>
> Let me reformat that :
>
> package /org/apache/directory/server/core/ is declared in modules core-api
> and core
> package /org/apache/directory/server/core/changelog/ is declared in modules
> core-api and core
> package /org/apache/directory/server/core/event/ is declared in modules
> core-api and core
> package /org/apache/directory/server/core/journal/ is declared in modules
> core-api and core
> package /org/apache/directory/server/core/partition/ is declared in modules
> core-api and core
> package /org/apache/directory/server/core/replication/ is declared in
> modules core-api and core
> package /org/apache/directory/server/core/schema/ is declared in modules
> core-api and core
>
> package /org/apache/directory/server/ is declared in modules
> http-directory-bridge, service, wrapper
> package /org/apache/directory/server/config/ is declared in modules
> server-config and service-builder
> package /org/apache/directory/server/core/integ/ is declared in modules
> core-integ and test-framework
> package /org/apache/directory/server/kerberos/protocol/ is declared in
> modules kerberos-codec and protocol-kerberos
> package /org/apache/directory/server/ldap/handlers/extended/ is declared in
> modules protocol-ldap and server-tools
>
> We just have 12 duplications, most of them being between core and core-api
> (which makes sense. Renaming the core packages by adding an impl can solve
> this issue.
>
>
These are the main PITA problems we need to grok to OSGify the server. Not a
big deal just labor but still a PITA. Thanks for putting this analysis out
there.

Regards,
Alex

Re: Apacheds package collision (OSGi)

[Alex Karasulu <ak...@apache.org>]

Sorry I don't get it, can you list which two artifacts contain the same
package instead of this listing?

On Wed, Apr 27, 2011 at 12:48 AM, Emmanuel Lecharny <el...@gmail.com>wrote:

> Hi guys,
>
> I have grepped the apacheds packages and classes. Here are the package that
> collide :
> /org/apache/directory/server/ ./http-directory-bridge/src/main/java
> /org/apache/directory/server/ ./service/src/main/java
> /org/apache/directory/server/ ./service/src/main/java
> /org/apache/directory/server/ ./wrapper/src/main/java
>
> /org/apache/directory/server/config/ ./server-config/src/main/java
> /org/apache/directory/server/config/ ./service-builder/src/main/java
>
> /org/apache/directory/server/core/ ./core-api/src/main/java
> /org/apache/directory/server/core/ ./core/src/main/java
>
> /org/apache/directory/server/core/changelog/ ./core-api/src/main/java
> /org/apache/directory/server/core/changelog/ ./core/src/main/java
>
> /org/apache/directory/server/core/event/ ./core-api/src/main/java
> /org/apache/directory/server/core/event/ ./core/src/main/java
>
> /org/apache/directory/server/core/integ/ ./core-integ/src/main/java
> /org/apache/directory/server/core/integ/ ./test-framework/src/main/java
>
> /org/apache/directory/server/core/journal/ ./core-api/src/main/java
> /org/apache/directory/server/core/journal/ ./core/src/main/java
>
> /org/apache/directory/server/core/partition/ ./core-api/src/main/java
> /org/apache/directory/server/core/partition/ ./core/src/main/java
>
> /org/apache/directory/server/core/replication/ ./core-api/src/main/java
> /org/apache/directory/server/core/replication/ ./core/src/main/java
>
> /org/apache/directory/server/core/schema/ ./core-api/src/main/java
> /org/apache/directory/server/core/schema/ ./core/src/main/java
>
> /org/apache/directory/server/kerberos/protocol/
> ./kerberos-codec/src/main/java
> /org/apache/directory/server/kerberos/protocol/
> ./protocol-kerberos/src/main/java
>
> /org/apache/directory/server/ldap/handlers/extended/
> ./protocol-ldap/src/main/java
> /org/apache/directory/server/ldap/handlers/extended/
> ./server-tools/src/main/java
>
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
>