You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2021/03/18 17:24:07 UTC

[kudu-CR] [thirdparty] Remove unnecessary clang usage for libcxxabi

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17203


Change subject: [thirdparty] Remove unnecessary clang usage for libcxxabi
......................................................................

[thirdparty] Remove unnecessary clang usage for libcxxabi

This patch removes the explicit usage of clang when compiling
libcxxabi which was done in 458e6ce to handle the lack of gcc5+
on all supported platforms. We now require gcc7+ as of e432e63.

Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27
---
M thirdparty/build-definitions.sh
1 file changed, 2 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/17203/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27
Gerrit-Change-Number: 17203
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [thirdparty] Remove unnecessary clang usage for libcxxabi

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17203 )

Change subject: [thirdparty] Remove unnecessary clang usage for libcxxabi
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17203/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17203/1//COMMIT_MSG@11
PS1, Line 11: We now require gcc7+ as of e432e63
Good point!



-- 
To view, visit http://gerrit.cloudera.org:8080/17203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27
Gerrit-Change-Number: 17203
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 18 Mar 2021 17:49:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] [thirdparty] Remove unnecessary clang usage for libcxxabi

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: [thirdparty] Remove unnecessary clang usage for libcxxabi
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/17203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27
Gerrit-Change-Number: 17203
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirdparty] Remove unnecessary clang usage for libcxxabi

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17203 )

Change subject: [thirdparty] Remove unnecessary clang usage for libcxxabi
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27
Gerrit-Change-Number: 17203
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 18 Mar 2021 19:23:36 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] Remove unnecessary clang usage for libcxxabi

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17203 )

Change subject: [thirdparty] Remove unnecessary clang usage for libcxxabi
......................................................................

[thirdparty] Remove unnecessary clang usage for libcxxabi

This patch removes the explicit usage of clang when compiling
libcxxabi which was done in 458e6ce to handle the lack of gcc5+
on all supported platforms. We now require gcc7+ as of e432e63.

Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27
Reviewed-on: http://gerrit.cloudera.org:8080/17203
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M thirdparty/build-definitions.sh
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Grant Henke: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I36a507d455a555cf71f100f54b41cfaba9da3a27
Gerrit-Change-Number: 17203
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)