You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2007/03/23 17:25:32 UTC
[jira] Created: (QPID-432) Client Code doesn't correctly close a
JMSSession/Channel when the broker demands it.
Client Code doesn't correctly close a JMSSession/Channel when the broker demands it.
------------------------------------------------------------------------------------
Key: QPID-432
URL: https://issues.apache.org/jira/browse/QPID-432
Project: Qpid
Issue Type: Bug
Components: Java Client
Reporter: Martin Ritchie
When a Channel exception occurs the Java client propogates the error but doesn't remove the JMSSession mapping from the connection so when connection.close is called the already closed AMQP-Channel is closed again.. resulting in a ConnectionException.
See AMQProtocolSession for where the execption is progogated and ignored
See Also ChannelCloseException for where the session is only removed from the map when a channel close is received with error code REPLY_SUCCESS other wise it thows an exception before calling this code.. should the code be in a finally?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-432) Client Code doesn't correctly close a
JMSSession/Channel when the broker demands it.
Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marnie McCormack updated QPID-432:
----------------------------------
Fix Version/s: (was: M4)
Descoping items not being worked on for M4 into Unknown Fix Version for now
> Client Code doesn't correctly close a JMSSession/Channel when the broker demands it.
> ------------------------------------------------------------------------------------
>
> Key: QPID-432
> URL: https://issues.apache.org/jira/browse/QPID-432
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> When a Channel exception occurs the Java client propogates the error but doesn't remove the JMSSession mapping from the connection so when connection.close is called the already closed AMQP-Channel is closed again.. resulting in a ConnectionException.
> See AMQProtocolSession for where the execption is progogated and ignored
> See Also ChannelCloseException for where the session is only removed from the map when a channel close is received with error code REPLY_SUCCESS other wise it thows an exception before calling this code.. should the code be in a finally?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-432) Client Code doesn't correctly close a
JMSSession/Channel when the broker demands it.
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-432:
--------------------------------
Fix Version/s: M3
> Client Code doesn't correctly close a JMSSession/Channel when the broker demands it.
> ------------------------------------------------------------------------------------
>
> Key: QPID-432
> URL: https://issues.apache.org/jira/browse/QPID-432
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Martin Ritchie
> Assigned To: Tejeswar Das
> Fix For: M3
>
>
> When a Channel exception occurs the Java client propogates the error but doesn't remove the JMSSession mapping from the connection so when connection.close is called the already closed AMQP-Channel is closed again.. resulting in a ConnectionException.
> See AMQProtocolSession for where the execption is progogated and ignored
> See Also ChannelCloseException for where the session is only removed from the map when a channel close is received with error code REPLY_SUCCESS other wise it thows an exception before calling this code.. should the code be in a finally?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Assigned: (QPID-432) Client Code doesn't correctly close
a JMSSession/Channel when the broker demands it.
Posted by Carl Trieloff <cc...@redhat.com>.
Rajith has a client re-factor on the branch, you might want to connect
with him as all the JMS stuff is in the client.
Carl.
Tejeswar Das (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/QPID-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Tejeswar Das reassigned QPID-432:
> ---------------------------------
>
> Assignee: Tejeswar Das
>
>
>> Client Code doesn't correctly close a JMSSession/Channel when the broker demands it.
>> ------------------------------------------------------------------------------------
>>
>> Key: QPID-432
>> URL: https://issues.apache.org/jira/browse/QPID-432
>> Project: Qpid
>> Issue Type: Bug
>> Components: Java Client
>> Reporter: Martin Ritchie
>> Assigned To: Tejeswar Das
>>
>> When a Channel exception occurs the Java client propogates the error but doesn't remove the JMSSession mapping from the connection so when connection.close is called the already closed AMQP-Channel is closed again.. resulting in a ConnectionException.
>> See AMQProtocolSession for where the execption is progogated and ignored
>> See Also ChannelCloseException for where the session is only removed from the map when a channel close is received with error code REPLY_SUCCESS other wise it thows an exception before calling this code.. should the code be in a finally?
>>
>
>
[jira] Assigned: (QPID-432) Client Code doesn't correctly close a
JMSSession/Channel when the broker demands it.
Posted by "Tejeswar Das (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tejeswar Das reassigned QPID-432:
---------------------------------
Assignee: Tejeswar Das
> Client Code doesn't correctly close a JMSSession/Channel when the broker demands it.
> ------------------------------------------------------------------------------------
>
> Key: QPID-432
> URL: https://issues.apache.org/jira/browse/QPID-432
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Martin Ritchie
> Assigned To: Tejeswar Das
>
> When a Channel exception occurs the Java client propogates the error but doesn't remove the JMSSession mapping from the connection so when connection.close is called the already closed AMQP-Channel is closed again.. resulting in a ConnectionException.
> See AMQProtocolSession for where the execption is progogated and ignored
> See Also ChannelCloseException for where the session is only removed from the map when a channel close is received with error code REPLY_SUCCESS other wise it thows an exception before calling this code.. should the code be in a finally?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-432) Client Code doesn't correctly close a
JMSSession/Channel when the broker demands it.
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-432:
-----------------------------------
Assignee: Martin Ritchie (was: Tejeswar Das)
> Client Code doesn't correctly close a JMSSession/Channel when the broker demands it.
> ------------------------------------------------------------------------------------
>
> Key: QPID-432
> URL: https://issues.apache.org/jira/browse/QPID-432
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M3
>
>
> When a Channel exception occurs the Java client propogates the error but doesn't remove the JMSSession mapping from the connection so when connection.close is called the already closed AMQP-Channel is closed again.. resulting in a ConnectionException.
> See AMQProtocolSession for where the execption is progogated and ignored
> See Also ChannelCloseException for where the session is only removed from the map when a channel close is received with error code REPLY_SUCCESS other wise it thows an exception before calling this code.. should the code be in a finally?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-432) Client Code doesn't correctly close a
JMSSession/Channel when the broker demands it.
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616133#action_12616133 ]
Martin Ritchie commented on QPID-432:
-------------------------------------
The ChannelCloseMethodHandler in client still only calls session.channelClosed in success cases so there may still be an issue of double closures.
Not sure where propagated exception is being ignored in AMQProtocolSession but it does now (as of QPID-940) propagate exceptions sent via notifyError()
We don't have a ChannelCloseException anymore but in ConnectionCloseMH we now correctly throw the exception back via session.notifyError() before closing the connection.
> Client Code doesn't correctly close a JMSSession/Channel when the broker demands it.
> ------------------------------------------------------------------------------------
>
> Key: QPID-432
> URL: https://issues.apache.org/jira/browse/QPID-432
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M3
>
>
> When a Channel exception occurs the Java client propogates the error but doesn't remove the JMSSession mapping from the connection so when connection.close is called the already closed AMQP-Channel is closed again.. resulting in a ConnectionException.
> See AMQProtocolSession for where the execption is progogated and ignored
> See Also ChannelCloseException for where the session is only removed from the map when a channel close is received with error code REPLY_SUCCESS other wise it thows an exception before calling this code.. should the code be in a finally?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.