You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Christian Lavoie (JIRA)" <ji...@apache.org> on 2010/10/12 07:45:32 UTC

[jira] Created: (THRIFT-953) make check fails in TransportTest.cpp

make check fails in TransportTest.cpp
-------------------------------------

                 Key: THRIFT-953
                 URL: https://issues.apache.org/jira/browse/THRIFT-953
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Compiler, C++ - Library
    Affects Versions: 0.6, 0.7
         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
            Reporter: Christian Lavoie
            Assignee: David Reiss


{{make -j2 check}} fails on my box with the following:

{noformat}

g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
TransportTest.cpp: In function 'void set_alarm()':
TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
make[4]: *** [TransportTest.o] Error 1
make[4]: *** Waiting for unfinished jobs....
mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
make[3]: *** [check-am] Error 2
make[2]: *** [check-recursive] Error 1
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1
{noformat}

Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922316#action_12922316 ] 

Christian Lavoie commented on THRIFT-953:
-----------------------------------------


That's all fine and dandy, but gettimeofday works everywhere, and
clock_realtime doesn't.


I'd need to investigate the latter (though it does sound like the
right thing). Would you be fine committing this as is and filing a bug
against me to investigate?




-- 
Have fun, Christian
http://linkedin.christianlavoie.net

"I won't let you fall apart."



> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch, v1-make-transportest-compile.patch, v2-fix-usage-of-linux-only-functions.patch, v3-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Lavoie updated THRIFT-953:
------------------------------------

    Attachment: v1-make-transportest-compile.patch

This gets {{TransportTest}} to compile and run successfully (with no failures) on my box:

{noformat}
$ port version ; echo ; port list | grep -i boost ; echo ; uname -a ; echo ; g++ --version
Version: 1.9.1

boost                          @1.44.0         devel/boost
boost-build                    @2.0-m12        devel/boost-build
boost-gil-numeric              @1.0            devel/boost-gil-numeric
boost-jam                      @3.1.18         devel/boost-jam

Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386

i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
{noformat}

This patch depends on {{v3-fix-usage-of-linux-only-functions.patch}} -- David, can you test this one on a linux machine? Shouldn't break anything -- but without it my version of {{libtool}} barfs, specifically, it rejects {{-l:libboost_unit_test_framework.a}}:

{noformat}
$ libtool -V
Apple Computer, Inc. version cctools-782
{noformat}

> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch, v1-make-transportest-compile.patch, v2-fix-usage-of-linux-only-functions.patch, v3-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921734#action_12921734 ] 

David Reiss commented on THRIFT-953:
------------------------------------

The first hunk looks great.

The second hunk should not delete that comment.

clock_gettime is defintely POSIX.  Weird that this doesn't work on your system.  However, using time is probably fine.  The only downside that I know of is that if you run the program twice in one second, you get the same seed.  However, this program takes more than one second to run, right?

There is no need to call srand and rand.  You can just use the time as the seed.

> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921879#action_12921879 ] 

Roger Meier commented on THRIFT-953:
------------------------------------

(y) , tested with the latest two patches on GNU/Linux Debian Lenny

> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch, v1-make-transportest-compile.patch, v2-fix-usage-of-linux-only-functions.patch, v3-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922158#action_12922158 ] 

David Reiss commented on THRIFT-953:
------------------------------------

The gettimeofday change is fine, though that function has been deprecated in favor of clock_gettime. :)

I'd prefer if we could come up with a solution that wouldn't require further forking of ax_boost_base.  Is it possible to get this changed pushed back upstream, or even use the autoconf macro archive's test for boost unit test?

> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch, v1-make-transportest-compile.patch, v2-fix-usage-of-linux-only-functions.patch, v3-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Lavoie updated THRIFT-953:
------------------------------------

    Attachment: v2-fix-usage-of-linux-only-functions.patch

I assumed it wasn't POSIX since it wasn't on Mac OS X: http://juliusdavies.ca/posix_clocks/clock_realtime_macosx_faq.html -- mea culpa, looks like just more madness from Apple.

v2 addresses both of David's comments.

BTW, something I should have mentioned earlier, it doesn't actually make the test pass on my machine, just allows it to compile again. It fails to build on my machine:

{noformat}
/bin/sh ../../../libtool --tag=CXX   --mode=link g++  -g -O2   -o TransportTest TransportTest.o libtestgencpp.la ../../../lib/cpp/libthriftz.la -l:libboost_unit_test_framework.a -lz -lpthread 
libtool: link: g++ -g -O2 -o .libs/TransportTest TransportTest.o -Wl,-bind_at_load  ./.libs/libtestgencpp.a /Users/moosefish/ports/src/thrift-svn-3/lib/cpp/.libs/libthrift.dylib ../../../lib/cpp/.libs/libthriftz.dylib -l:libboost_unit_test_framework.a -lz -lpthread
ld: library not found for -l:libboost_unit_test_framework.a
collect2: ld returned 1 exit status
make[4]: *** [TransportTest] Error 1
make[3]: *** [check-am] Error 2
make[2]: *** [check-recursive] Error 1
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1
{noformat}

But if I link it by hand and then run it, it dies anyway:

{noformat}
$ g++ -g -O2 -o .libs/TransportTest TransportTest.o -Wl,-bind_at_load  ./.libs/libtestgencpp.a /Users/moosefish/ports/src/thrift-svn-3/lib/cpp/.libs/libthrift.dylib ../../../lib/cpp/.libs/libthriftz.dylib /opt/local/lib/libboost_unit_test_framework.a  -lz -lpthread

$ ./.libs/TransportTest 
Running 265 test cases...
unknown location:0: fatal error in "CoupledZlibTransportsT<CoupledMemoryBuffers>::test_rw(1048576, 0, 0, 0, 0, 0)": std::exception: zlib error: buffer error (status = -5)
TransportTest.cpp:474: last checkpoint
unknown location:0: fatal error in "CoupledZlibTransportsT<CoupledMemoryBuffers>::test_rw(262144, rand(1, 4096), rand(1, 4096), 0, 0, 0)": signal: SIGSEGV, si_code: 0 (memory access violation at address: 0x00000000)
TransportTest.cpp:474: last checkpoint

*** 2 failures detected in test suite "TransportTest"
{noformat}

However those look like completely orthogonal errors, so I recommend v2 be committed and I'll keep investigating when I have time. For the record, my machine is:

{noformat}
$ port list | grep -i boost
boost                          @1.44.0         devel/boost
boost-build                    @2.0-m12        devel/boost-build
boost-gil-numeric              @1.0            devel/boost-gil-numeric
boost-jam                      @3.1.18         devel/boost-jam

$ uname -a ; g++ --version
Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
{noformat}

> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch, v2-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922316#action_12922316 ] 

Christian Lavoie edited comment on THRIFT-953 at 10/18/10 6:21 PM:
-------------------------------------------------------------------

That's all fine and dandy, but gettimeofday works everywhere, and
clock_realtime doesn't.


I'd need to investigate the latter (though it does sound like the
right thing). Would you be fine committing this as is and filing a bug
against me to investigate?

      was (Author: clavoie):
    
That's all fine and dandy, but gettimeofday works everywhere, and
clock_realtime doesn't.


I'd need to investigate the latter (though it does sound like the
right thing). Would you be fine committing this as is and filing a bug
against me to investigate?




-- 
Have fun, Christian
http://linkedin.christianlavoie.net

"I won't let you fall apart."


  
> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch, v1-make-transportest-compile.patch, v2-fix-usage-of-linux-only-functions.patch, v3-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921722#action_12921722 ] 

Roger Meier edited comment on THRIFT-953 at 10/16/10 2:06 PM:
--------------------------------------------------------------

I'm wondering, that clock_gettime is linux-only... see http://www.opengroup.org/onlinepubs/009695399/basedefs/time.h.html

However, srand/rand is a better alternative and being more POSIX conform is good!

from my perspective, this should be committed!

already tested on GNU/Linux Debian Lenny



      was (Author: roger.meier):
    I'm wondering, that clock_gettime is linux-only... see http://www.opengroup.org/onlinepubs/009695399/basedefs/time.h.html

However, srand/rand is a better alternative and being more POSIX conform is good!

from my perspective, this should be committed!


  
> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Lavoie updated THRIFT-953:
------------------------------------

    Attachment: v3-fix-usage-of-linux-only-functions.patch

David, this version addresses your time resolution concern by XOR'ing the tv_sec and tv_usec (microseconds) values from gettimeofday. Lemme know.

> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch, v2-fix-usage-of-linux-only-functions.patch, v3-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Lavoie updated THRIFT-953:
------------------------------------

    Attachment: v1-fix-usage-of-linux-only-functions.patch

{{SA_ONESHOT}} is a synonym for the POSIX-correct {{SA_RESETHAND}} (see http://lxr.oss.org.cn/ident?i=SA_ONESHOT, click on a few of the arch-specific headers).

{{clock_gettime}} (and {{CLOCK_REALTIME}}) are linux-only functions. Instead, use {{time(NULL)}} to get current time, feed that to {{srand}} and use {{rand()}} to seed our own (better) random number generator.

David, thoughts?

> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921722#action_12921722 ] 

Roger Meier commented on THRIFT-953:
------------------------------------

I'm wondering, that clock_gettime is linux-only... see http://www.opengroup.org/onlinepubs/009695399/basedefs/time.h.html

However, srand and rand is a good alternative and and beeing more POSIX conform is good!

from my perspective, this should be committed



> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922366#action_12922366 ] 

David Reiss commented on THRIFT-953:
------------------------------------

Sure.

> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch, v1-make-transportest-compile.patch, v2-fix-usage-of-linux-only-functions.patch, v3-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921778#action_12921778 ] 

David Reiss commented on THRIFT-953:
------------------------------------

I'm fine with this version.

> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch, v2-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (THRIFT-953) make check fails in TransportTest.cpp

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921722#action_12921722 ] 

Roger Meier edited comment on THRIFT-953 at 10/16/10 2:05 PM:
--------------------------------------------------------------

I'm wondering, that clock_gettime is linux-only... see http://www.opengroup.org/onlinepubs/009695399/basedefs/time.h.html

However, srand/rand is a better alternative and being more POSIX conform is good!

from my perspective, this should be committed!



      was (Author: roger.meier):
    I'm wondering, that clock_gettime is linux-only... see http://www.opengroup.org/onlinepubs/009695399/basedefs/time.h.html

However, srand and rand is a good alternative and and beeing more POSIX conform is good!

from my perspective, this should be committed


  
> make check fails in TransportTest.cpp
> -------------------------------------
>
>                 Key: THRIFT-953
>                 URL: https://issues.apache.org/jira/browse/THRIFT-953
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler, C++ - Library
>    Affects Versions: 0.6, 0.7
>         Environment: Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> i686-apple-darwin10-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664)
>            Reporter: Christian Lavoie
>            Assignee: David Reiss
>         Attachments: v1-fix-usage-of-linux-only-functions.patch
>
>
> {{make -j2 check}} fails on my box with the following:
> {noformat}
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT TransportTest.o -MD -MP -MF .deps/TransportTest.Tpo -c -o TransportTest.o TransportTest.cpp
> TransportTest.cpp: In function 'void set_alarm()':
> TransportTest.cpp:381: error: 'SA_ONESHOT' was not declared in this scope
> TransportTest.cpp: In function 'void parse_args(int, char**, Options*)':
> TransportTest.cpp:1028: error: 'CLOCK_REALTIME' was not declared in this scope
> TransportTest.cpp:1028: error: 'clock_gettime' was not declared in this scope
> mv -f .deps/AllProtocolTests.Tpo .deps/AllProtocolTests.Po
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src -I/opt/local/include   -g -O2 -MT ZlibTest.o -MD -MP -MF .deps/ZlibTest.Tpo -c -o ZlibTest.o ZlibTest.cpp
> make[4]: *** [TransportTest.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> mv -f .deps/ZlibTest.Tpo .deps/ZlibTest.Po
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
> {noformat}
> Only affects HEAD, not 0.5.0; seems related to latest facebook changes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.