Re: [PR] feat: add `/api/job/{job_id}/config` endpoint to retrieve session configuration [datafusion-ballista]

["milenkovicm (via GitHub)" <gi...@apache.org>]

milenkovicm commented on code in PR #1792:
URL: https://github.com/apache/datafusion-ballista/pull/1792#discussion_r3324675862


##########
ballista/scheduler/src/state/task_manager.rs:
##########
@@ -440,6 +440,16 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> TaskManager<T, U>
         }
     }
 
+    /// Get the session configuration for a job.
+    pub async fn get_job_config(&self, job_id: &str) -> Result<HashMap<String, String>> {

Review Comment:
   can we make this method return `SessionConfig` and we we map to hash map in the handler code ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org