[GitHub] [apisix] soulbird commented on a diff in pull request #9510: fix(admin): fix secrets do not support to update attributes by PATCH

["soulbird (via GitHub)" <gi...@apache.org>]

soulbird commented on code in PR #9510:
URL: https://github.com/apache/apisix/pull/9510#discussion_r1201416649


##########
t/admin/secrets.t:
##########
@@ -169,7 +169,69 @@ passed
 
 
 
-=== TEST 5: DELETE
+=== TEST 5: PATCH
+--- config
+    location /t {
+        content_by_lua_block {
+            local t = require("lib.test_admin").test
+            local etcd = require("apisix.core.etcd")
+            local res = assert(etcd.get('/secrets/vault/test1'))
+            local prev_create_time = res.body.node.value.create_time
+            assert(prev_create_time ~= nil, "create_time is nil")
+            local prev_update_time = res.body.node.value.update_time
+            assert(prev_update_time ~= nil, "update_time is nil")
+            ngx.sleep(1)
+
+            local code, body = t('/apisix/admin/secrets/vault/test1',

Review Comment:
   Which field was modified? Didn't see how you verified the execution result of PATCH?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org