You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sumitagrawl (via GitHub)" <gi...@apache.org> on 2023/06/28 13:48:08 UTC
[GitHub] [ozone] sumitagrawl commented on a diff in pull request #4940: Recon UI:OM DB Insights Changes
sumitagrawl commented on code in PR #4940:
URL: https://github.com/apache/ozone/pull/4940#discussion_r1245229733
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -28,5 +28,44 @@
"/heatmap/readaccess?startDate=*&path=*&entityType=bucket": "/bucketHeatmap",
"/heatmap/readaccess?startDate=*&path=*&entityType=key": "/keyHeatmap",
"/heatmap/readaccess?startDate=*&path=*&entityType=volume": "/heatmap",
- "/features/disabledFeatures": "/disabledFeatures"
+ "/features/disabledFeatures": "/disabledFeatures",
+ "/keys/open?limit=0": "/keysOpenSummary",
+ "/keys/deletePending?limit=1": "/keysdeletePendingSummary",
Review Comment:
do limit=0 or limit=1 as used in URI as fixed is correct? Or this is only test URI ?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/routes.json:
##########
@@ -28,5 +28,44 @@
"/heatmap/readaccess?startDate=*&path=*&entityType=bucket": "/bucketHeatmap",
"/heatmap/readaccess?startDate=*&path=*&entityType=key": "/keyHeatmap",
"/heatmap/readaccess?startDate=*&path=*&entityType=volume": "/heatmap",
- "/features/disabledFeatures": "/disabledFeatures"
+ "/features/disabledFeatures": "/disabledFeatures",
+ "/keys/open?limit=0": "/keysOpenSummary",
+ "/keys/deletePending?limit=1": "/keysdeletePendingSummary",
+
+ "/containers/mismatch?limit=*&prevKey=11&missingIn=OM" : "/omMismatch1",
+ "/containers/mismatch?limit=*&prevKey=21&missingIn=OM" : "/omMismatch2",
+ "/containers/mismatch?limit=*&prevKey=31&missingIn=OM" : "/omMismatch3",
+ "/containers/mismatch?limit=*&prevKey=41&missingIn=OM" : "/omMismatch4",
+
+ "/containers/mismatch?limit=*&prevKey=*&missingIn=OM" : "/omMismatch",
Review Comment:
in this uri, /omMistmatch <-- this is test uri or normal uri? how about omMismatch1, omMistmatch2, ...
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -101,8 +113,10 @@ export class Overview extends React.Component<Record<string, object>, IOverviewS
});
axios.all([
axios.get('/api/v1/clusterState'),
- axios.get('/api/v1/task/status')
- ]).then(axios.spread((clusterStateResponse, taskstatusResponse) => {
+ axios.get('/api/v1/task/status'),
+ axios.get('/api/v1/keys/open?limit=0'),
+ axios.get('/api/v1/keys/deletePending?limit=1'),
Review Comment:
check if limit=1 or limit=1 is correctly used...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org