You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2014/06/26 02:57:00 UTC

Review Request 22993: [HELIX-463] Create useful message queue length jmx

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22993/
-----------------------------------------------------------

Review request for helix, Zhen Zhang and Kishore Gopalakrishna.


Bugs: HELIX-463


Repository: helix-git


Description
-------

commit 2e98a67a6212fda9b2648300d25adc6424eab5d9
Author: Kanak Biscuitwala <ka...@apache.org>
Date:   Wed Jun 25 17:42:45 2014 -0700

    [HELIX-463] Create useful message queue length jmx

:100644 100644 c322215... c6055c7... M	helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
:100644 100644 a4eaae3... b4efec4... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
:100644 100644 9070aaa... 9d15af9... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitorMBean.java
:100644 100644 6b8b9e3... 1ebf851... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitor.java
:100644 100644 acf3824... 14c0af5... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitorMBean.java
:100644 100644 0981a2e... b062282... M	helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java


Diffs
-----

  helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java c322215 
  helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java a4eaae3 
  helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitorMBean.java 9070aaa 
  helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitor.java 6b8b9e3 
  helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitorMBean.java acf3824 
  helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java 0981a2e 

Diff: https://reviews.apache.org/r/22993/diff/


Testing
-------


Thanks,

Kanak Biscuitwala

Re: Review Request 22993: [HELIX-463] Create useful message queue length jmx

Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22993/#review46765
-----------------------------------------------------------

Ship it!


Ship It!

- Zhen Zhang


On June 26, 2014, 12:56 a.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22993/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 12:56 a.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-463
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit 2e98a67a6212fda9b2648300d25adc6424eab5d9
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date:   Wed Jun 25 17:42:45 2014 -0700
> 
>     [HELIX-463] Create useful message queue length jmx
> 
> :100644 100644 c322215... c6055c7... M	helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
> :100644 100644 a4eaae3... b4efec4... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
> :100644 100644 9070aaa... 9d15af9... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitorMBean.java
> :100644 100644 6b8b9e3... 1ebf851... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitor.java
> :100644 100644 acf3824... 14c0af5... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitorMBean.java
> :100644 100644 0981a2e... b062282... M	helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java
> 
> 
> Diffs
> -----
> 
>   helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java c322215 
>   helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java a4eaae3 
>   helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitorMBean.java 9070aaa 
>   helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitor.java 6b8b9e3 
>   helix-core/src/main/java/org/apache/helix/monitoring/mbeans/MessageQueueMonitorMBean.java acf3824 
>   helix-core/src/test/java/org/apache/helix/monitoring/TestClusterStatusMonitorLifecycle.java 0981a2e 
> 
> Diff: https://reviews.apache.org/r/22993/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>