You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/02 14:53:57 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request, #4237: Fix #3951 to add a test with quarkus-pooled-jms
zhfeng opened a new pull request, #4237:
URL: https://github.com/apache/camel-quarkus/pull/4237
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4237: Fix #3951 to add a test with quarkus-pooled-jms
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #4237:
URL: https://github.com/apache/camel-quarkus/pull/4237#issuecomment-1301884068
OK, I add `<resolutionEntryPointInclude>io.quarkiverse.messaginghub:*</resolutionEntryPointInclude>` to sort it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4237: Fix #3951 to add a test with quarkus-pooled-jms
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #4237:
URL: https://github.com/apache/camel-quarkus/pull/4237#issuecomment-1301861695
@jamesnetherton @ppalaga
Hmm, I moved `quarkus-pooled-jms` to `camel-quarkus-bom` but it can not be included in `poms/bom/src/main/generated/flattened-reduced-pom.xml`. I guess it is becaus there is no extension directly depends on it. I tried to add it as an optional dependency in `extensions/jms/runtime/pom.xml` and it works. So is it right or anything I missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4237: Fix #3951 to add a test with quarkus-pooled-jms
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #4237:
URL: https://github.com/apache/camel-quarkus/pull/4237#issuecomment-1301802877
No, it looks like I added it in a wrong BOM. I think we should manage it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng merged pull request #4237: Fix #3951 to add a test with quarkus-pooled-jms
Posted by GitBox <gi...@apache.org>.
zhfeng merged PR #4237:
URL: https://github.com/apache/camel-quarkus/pull/4237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4237: Fix #3951 to add a test with quarkus-pooled-jms
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on PR #4237:
URL: https://github.com/apache/camel-quarkus/pull/4237#issuecomment-1301795073
Just so I understand things - we're not adding `quarkus-pooled-jms` to `camel-quarkus-bom` because there are some issues to resolve? So for now we just add to the test BOM for our internal testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org