You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Karl Wright (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2012/01/11 01:40:39 UTC
[jira] [Issue Comment Edited] (SOLR-3015) CloseHook cannot be used
with QParserPlugins
[ https://issues.apache.org/jira/browse/SOLR-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183742#comment-13183742 ]
Karl Wright edited comment on SOLR-3015 at 1/11/12 12:40 AM:
-------------------------------------------------------------
Making it possible for a QParserPlugin to be SolrCoreAware seems to work fine. But one other thing that happens that is a bit of a surprise is that TWO copies of the QParserPlugin class are created. So I get two sets of resources allocated, and two freed. This is for lucene/solr trunk; haven't tried this diagnostic for 3.x yet. I was able to verify that SearchComponents behave in exactly the same way, though, so this is not related to QParserPlugins per se.
was (Author: kwright@metacarta.com):
Making it possible for a QParserPlugin to be SolrCoreAware seems to work fine. But one other thing that happens that is a bit of a surprise is that TWO copies of the QParserPlugin class are created. So I get two sets of resources allocated, and two freed. This is for lucene/solr trunk; haven't tried this diagnostic for 3.x yet.
> CloseHook cannot be used with QParserPlugins
> --------------------------------------------
>
> Key: SOLR-3015
> URL: https://issues.apache.org/jira/browse/SOLR-3015
> Project: Solr
> Issue Type: Bug
> Reporter: Karl Wright
> Labels: closehook, qparserplugin, solrcoreaware
> Attachments: SOLR-3015.patch
>
>
> For some kinds of plugins, the CloseHook API works well to allow the plugin to clean up any resources it was using prior to Solr shutdown. But for QParserPlugins, CloseHook does not work; you get an error if you try to use it. This occurs because the QParserPlugin cannot be made SolrCoreAware:
> {code}
> [junit] org.apache.solr.common.SolrException: Invalid 'Aware' object: org.apache.solr.mcf.ManifoldCFQParserPlugin@18941f7 -- org.apache.solr.util.plugin.SolrCoreAware must be an instance of: [org.apache.solr.request.SolrRequestHandler]
> [org.apache.solr.response.QueryResponseWriter] [org.apache.solr.handler.component.SearchComponent] [org.apache.solr.update.processor.UpdateRequestProcessorFactory] [org.apache.solr.handler.component.ShardHandlerFactory]
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org