You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by dan <da...@gmail.com> on 2017/05/02 20:48:25 UTC
[DISCUSS] KIP 151 - Expose Connector type in REST API
hello.
in an attempt to make the connect rest endpoints more useful i'd like to
add the Connector type (Sink/Source) in our rest endpoints to make them
more self descriptive.
KIP here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-151+Expose+Connector+type+in+REST+API
initial pr: https://github.com/apache/kafka/pull/2960
thanks
dan
Re: [DISCUSS] KIP 151 - Expose Connector type in REST API
Posted by Gwen Shapira <gw...@confluent.io>.
How about also adding the path from which we loaded the connector (since
users run into issues where they are actually running a different connector
than they think they are running)?
If you think this is too complex or out of scope, no big deal. But it is a
"nice to have" feature.
On Sun, May 7, 2017 at 4:58 PM Konstantine Karantasis <
konstantine@confluent.io> wrote:
> Nice. Thanks!
>
> -Konstantine
>
> On Sat, May 6, 2017 at 10:43 PM, dan <da...@gmail.com> wrote:
>
> > thanks for the feedback, it all sounds good. i have made the changes to
> the
> > pr and the kip.
> >
> > dan
> >
> > On Fri, May 5, 2017 at 9:29 AM, Konstantine Karantasis <
> > konstantine@confluent.io> wrote:
> >
> > > Thank you for the KIP. It's a nice improvement.
> > >
> > > Two small suggestions:
> > >
> > > 1) Let's not use all caps to describe the type of the connector.
> "Source"
> > > and "Sink" seem more appropriate (but even all lower case would be
> > better).
> > > 2) It's been discussed in other contexts recently, but I believe
> finally
> > > exposing a connector's version here makes more sense than anywhere else
> > at
> > > the moment. There's an existing interface method to grab the version,
> and
> > > publishing it through REST is not affected by any conventions made with
> > > respect to versioning format (also sorting based on name and version I
> > > guess is a concern that can be postponed to when we support multiple
> > > versions of the same connector and this doesn't have to be addressed
> on a
> > > KIP anyways).
> > >
> > > Let me know what you think. I'll add comments to the PR as well.
> > > Thanks again.
> > >
> > > -Konstantine
> > >
> > > On Thu, May 4, 2017 at 4:20 PM, Gwen Shapira <gw...@confluent.io>
> wrote:
> > >
> > > > YES PLEASE!
> > > >
> > > > On Tue, May 2, 2017 at 1:48 PM, dan <da...@gmail.com> wrote:
> > > >
> > > > > hello.
> > > > >
> > > > > in an attempt to make the connect rest endpoints more useful i'd
> like
> > > to
> > > > > add the Connector type (Sink/Source) in our rest endpoints to make
> > them
> > > > > more self descriptive.
> > > > >
> > > > > KIP here:
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > 151+Expose+Connector+type+in+REST+API
> > > > > initial pr: https://github.com/apache/kafka/pull/2960
> > > > >
> > > > > thanks
> > > > > dan
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > *Gwen Shapira*
> > > > Product Manager | Confluent
> > > > 650.450.2760 <(650)%20450-2760> | @gwenshap
> > > > Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
> > > > <http://www.confluent.io/blog>
> > > >
> > >
> >
>
Re: [DISCUSS] KIP 151 - Expose Connector type in REST API
Posted by Konstantine Karantasis <ko...@confluent.io>.
Nice. Thanks!
-Konstantine
On Sat, May 6, 2017 at 10:43 PM, dan <da...@gmail.com> wrote:
> thanks for the feedback, it all sounds good. i have made the changes to the
> pr and the kip.
>
> dan
>
> On Fri, May 5, 2017 at 9:29 AM, Konstantine Karantasis <
> konstantine@confluent.io> wrote:
>
> > Thank you for the KIP. It's a nice improvement.
> >
> > Two small suggestions:
> >
> > 1) Let's not use all caps to describe the type of the connector. "Source"
> > and "Sink" seem more appropriate (but even all lower case would be
> better).
> > 2) It's been discussed in other contexts recently, but I believe finally
> > exposing a connector's version here makes more sense than anywhere else
> at
> > the moment. There's an existing interface method to grab the version, and
> > publishing it through REST is not affected by any conventions made with
> > respect to versioning format (also sorting based on name and version I
> > guess is a concern that can be postponed to when we support multiple
> > versions of the same connector and this doesn't have to be addressed on a
> > KIP anyways).
> >
> > Let me know what you think. I'll add comments to the PR as well.
> > Thanks again.
> >
> > -Konstantine
> >
> > On Thu, May 4, 2017 at 4:20 PM, Gwen Shapira <gw...@confluent.io> wrote:
> >
> > > YES PLEASE!
> > >
> > > On Tue, May 2, 2017 at 1:48 PM, dan <da...@gmail.com> wrote:
> > >
> > > > hello.
> > > >
> > > > in an attempt to make the connect rest endpoints more useful i'd like
> > to
> > > > add the Connector type (Sink/Source) in our rest endpoints to make
> them
> > > > more self descriptive.
> > > >
> > > > KIP here:
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 151+Expose+Connector+type+in+REST+API
> > > > initial pr: https://github.com/apache/kafka/pull/2960
> > > >
> > > > thanks
> > > > dan
> > > >
> > >
> > >
> > >
> > > --
> > > *Gwen Shapira*
> > > Product Manager | Confluent
> > > 650.450.2760 | @gwenshap
> > > Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
> > > <http://www.confluent.io/blog>
> > >
> >
>
Re: [DISCUSS] KIP 151 - Expose Connector type in REST API
Posted by dan <da...@gmail.com>.
thanks for the feedback, it all sounds good. i have made the changes to the
pr and the kip.
dan
On Fri, May 5, 2017 at 9:29 AM, Konstantine Karantasis <
konstantine@confluent.io> wrote:
> Thank you for the KIP. It's a nice improvement.
>
> Two small suggestions:
>
> 1) Let's not use all caps to describe the type of the connector. "Source"
> and "Sink" seem more appropriate (but even all lower case would be better).
> 2) It's been discussed in other contexts recently, but I believe finally
> exposing a connector's version here makes more sense than anywhere else at
> the moment. There's an existing interface method to grab the version, and
> publishing it through REST is not affected by any conventions made with
> respect to versioning format (also sorting based on name and version I
> guess is a concern that can be postponed to when we support multiple
> versions of the same connector and this doesn't have to be addressed on a
> KIP anyways).
>
> Let me know what you think. I'll add comments to the PR as well.
> Thanks again.
>
> -Konstantine
>
> On Thu, May 4, 2017 at 4:20 PM, Gwen Shapira <gw...@confluent.io> wrote:
>
> > YES PLEASE!
> >
> > On Tue, May 2, 2017 at 1:48 PM, dan <da...@gmail.com> wrote:
> >
> > > hello.
> > >
> > > in an attempt to make the connect rest endpoints more useful i'd like
> to
> > > add the Connector type (Sink/Source) in our rest endpoints to make them
> > > more self descriptive.
> > >
> > > KIP here:
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 151+Expose+Connector+type+in+REST+API
> > > initial pr: https://github.com/apache/kafka/pull/2960
> > >
> > > thanks
> > > dan
> > >
> >
> >
> >
> > --
> > *Gwen Shapira*
> > Product Manager | Confluent
> > 650.450.2760 | @gwenshap
> > Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
> > <http://www.confluent.io/blog>
> >
>
Re: [DISCUSS] KIP 151 - Expose Connector type in REST API
Posted by Konstantine Karantasis <ko...@confluent.io>.
Thank you for the KIP. It's a nice improvement.
Two small suggestions:
1) Let's not use all caps to describe the type of the connector. "Source"
and "Sink" seem more appropriate (but even all lower case would be better).
2) It's been discussed in other contexts recently, but I believe finally
exposing a connector's version here makes more sense than anywhere else at
the moment. There's an existing interface method to grab the version, and
publishing it through REST is not affected by any conventions made with
respect to versioning format (also sorting based on name and version I
guess is a concern that can be postponed to when we support multiple
versions of the same connector and this doesn't have to be addressed on a
KIP anyways).
Let me know what you think. I'll add comments to the PR as well.
Thanks again.
-Konstantine
On Thu, May 4, 2017 at 4:20 PM, Gwen Shapira <gw...@confluent.io> wrote:
> YES PLEASE!
>
> On Tue, May 2, 2017 at 1:48 PM, dan <da...@gmail.com> wrote:
>
> > hello.
> >
> > in an attempt to make the connect rest endpoints more useful i'd like to
> > add the Connector type (Sink/Source) in our rest endpoints to make them
> > more self descriptive.
> >
> > KIP here:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 151+Expose+Connector+type+in+REST+API
> > initial pr: https://github.com/apache/kafka/pull/2960
> >
> > thanks
> > dan
> >
>
>
>
> --
> *Gwen Shapira*
> Product Manager | Confluent
> 650.450.2760 | @gwenshap
> Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
> <http://www.confluent.io/blog>
>
Re: [DISCUSS] KIP 151 - Expose Connector type in REST API
Posted by Gwen Shapira <gw...@confluent.io>.
YES PLEASE!
On Tue, May 2, 2017 at 1:48 PM, dan <da...@gmail.com> wrote:
> hello.
>
> in an attempt to make the connect rest endpoints more useful i'd like to
> add the Connector type (Sink/Source) in our rest endpoints to make them
> more self descriptive.
>
> KIP here:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 151+Expose+Connector+type+in+REST+API
> initial pr: https://github.com/apache/kafka/pull/2960
>
> thanks
> dan
>
--
*Gwen Shapira*
Product Manager | Confluent
650.450.2760 | @gwenshap
Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
<http://www.confluent.io/blog>
Re: [DISCUSS] KIP 151 - Expose Connector type in REST API
Posted by Ewen Cheslack-Postava <ew...@confluent.io>.
Both the proposal and PR look good to me.
-Ewen
On Tue, May 2, 2017 at 1:48 PM, dan <da...@gmail.com> wrote:
> hello.
>
> in an attempt to make the connect rest endpoints more useful i'd like to
> add the Connector type (Sink/Source) in our rest endpoints to make them
> more self descriptive.
>
> KIP here:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 151+Expose+Connector+type+in+REST+API
> initial pr: https://github.com/apache/kafka/pull/2960
>
> thanks
> dan
>