Re: [PR] Remove unused Ruby client reply helpers [thrift]

["kpumuk (via GitHub)" <gi...@apache.org>]

kpumuk commented on PR #3395:
URL: https://github.com/apache/thrift/pull/3395#issuecomment-4265113129

   @Jens-G this is somewhat a lower risk PR, do you mind if I merge it to practice? I was looking at https://thrift.apache.org/docs/committers/HowToCommit.html and it seem kind of outdated. Thinking about something like
   
   ```bash
   gh api -H "Accept: application/vnd.github.v3.patch" repos/:owner/:repo/pulls/3395 | git am --ignore-space-change
    
   git log --format=fuller -n1
   ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   commit 77151745bac95752cf2d745215c7639ffcd114a5 (HEAD -> master)
   Author:     Dmytro Shteflyuk <kp...@apache.org>
   AuthorDate: Thu Apr 16 22:24:48 2026 -0400
   Commit:     Dmytro Shteflyuk <kp...@apache.org>
   CommitDate: Thu Apr 16 23:40:35 2026 -0400
   
       Remove unused Ruby client reply helpers
   ```
   
   Output seems to match (somewhat) what you have been doing. Would probably add Client as well, not quite sure how `Patch` is relevant given `Author` is preserved as is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org