You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-dev@hadoop.apache.org by Haosong Huang <ha...@gmail.com> on 2013/11/14 19:33:51 UTC
About submit patch workflow
Dear all, I am not familar with the workflow about how to submit patch. I
don't know what should I do after I attach patch and submit it on jira. How
I could get any review advices? Should I post it to reviewboard? For
example, I attach files to
YARN-1375<https://issues.apache.org/jira/browse/YARN-1375>
and YARN-1329 <https://issues.apache.org/jira/browse/YARN-1329>, and which
step should I do next? Thank you very much.
--
Best Regards,
Haosdent Huang
Re: About submit patch workflow
Posted by Haosong Huang <ha...@gmail.com>.
Thank you very much. :-)
On Fri, Nov 15, 2013 at 2:03 PM, Jun Ping Du <jd...@vmware.com> wrote:
> Hi Haosong,
> Not necessary to post patch to reviewboard (I don't know if any), but
> just need to refine your patch if Jenkins complain (in your case, no unit
> tests included) or wait a while for comments from other
> committers/contributors who are watching this JIRA. Hope it helps.
>
> Thanks,
>
> Junping
>
> ----- Original Message -----
> From: "Haosong Huang" >
> To: yarn-dev@hadoop.apache.org
> Sent: Friday, November 15, 2013 2:33:51 AM
> Subject: About submit patch workflow
>
> Dear all, I am not familar with the workflow about how to submit patch. I
> don't know what should I do after I attach patch and submit it on jira. How
> I could get any review advices? Should I post it to reviewboard? For
> example, I attach files to
> YARN-1375<
> https://urldefense.proofpoint.com/v1/url?u=https://issues.apache.org/jira/browse/YARN-1375&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=Mw3izENeqbMFnOzHo594vQ%3D%3D%0A&m=IXya3fC2epDoMTdnYm2wff7MbRf1QBPi%2FO6I98unX64%3D%0A&s=28d478a9c10b337f1932e655244ffa9b03fa3a91dd64d285f604a410fe8453a5
> >
> and YARN-1329 <
> https://urldefense.proofpoint.com/v1/url?u=https://issues.apache.org/jira/browse/YARN-1329&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=Mw3izENeqbMFnOzHo594vQ%3D%3D%0A&m=IXya3fC2epDoMTdnYm2wff7MbRf1QBPi%2FO6I98unX64%3D%0A&s=8fc16a93c37ed0496eac2e9aac7b177f2fd75a9619ee4099dbcadd542eb018b9>,
> and which
> step should I do next? Thank you very much.
>
> --
> Best Regards,
> Haosdent Huang
>
--
Best Regards,
Haosdent Huang
Re: About submit patch workflow
Posted by Jun Ping Du <jd...@vmware.com>.
Hi Haosong,
Not necessary to post patch to reviewboard (I don't know if any), but just need to refine your patch if Jenkins complain (in your case, no unit tests included) or wait a while for comments from other committers/contributors who are watching this JIRA. Hope it helps.
Thanks,
Junping
----- Original Message -----
From: "Haosong Huang" >
To: yarn-dev@hadoop.apache.org
Sent: Friday, November 15, 2013 2:33:51 AM
Subject: About submit patch workflow
Dear all, I am not familar with the workflow about how to submit patch. I
don't know what should I do after I attach patch and submit it on jira. How
I could get any review advices? Should I post it to reviewboard? For
example, I attach files to
YARN-1375<https://urldefense.proofpoint.com/v1/url?u=https://issues.apache.org/jira/browse/YARN-1375&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=Mw3izENeqbMFnOzHo594vQ%3D%3D%0A&m=IXya3fC2epDoMTdnYm2wff7MbRf1QBPi%2FO6I98unX64%3D%0A&s=28d478a9c10b337f1932e655244ffa9b03fa3a91dd64d285f604a410fe8453a5>
and YARN-1329 <https://urldefense.proofpoint.com/v1/url?u=https://issues.apache.org/jira/browse/YARN-1329&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=Mw3izENeqbMFnOzHo594vQ%3D%3D%0A&m=IXya3fC2epDoMTdnYm2wff7MbRf1QBPi%2FO6I98unX64%3D%0A&s=8fc16a93c37ed0496eac2e9aac7b177f2fd75a9619ee4099dbcadd542eb018b9>, and which
step should I do next? Thank you very much.
--
Best Regards,
Haosdent Huang