You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Hemant Kumar (Jira)" <ji...@apache.org> on 2024/08/07 18:24:00 UTC
[jira] [Comment Edited] (HDDS-9198) Snapshot purge should be a atomic operation
[ https://issues.apache.org/jira/browse/HDDS-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871477#comment-17871477 ]
Hemant Kumar edited comment on HDDS-9198 at 8/7/24 6:23 PM:
------------------------------------------------------------
As maintained in [comment#6491,|https://github.com/apache/ozone/pull/6491#issuecomment-2272219528,] we can keep the batch purge if we use a single map. Will create new PR to use single map.
was (Author: JIRAUSER297350):
As maintained in [comment#6491,|https://github.com/apache/ozone/pull/6491#issuecomment-2272219528,] we can keep the batch purge if we use a single map. Closing it for now and will reopen it or create a new jira if we see any consistency issues even after HDDS-11137/[#7018.|https://github.com/apache/ozone/pull/7018]
> Snapshot purge should be a atomic operation
> -------------------------------------------
>
> Key: HDDS-9198
> URL: https://issues.apache.org/jira/browse/HDDS-9198
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Hemant Kumar
> Assignee: Hemant Kumar
> Priority: Major
> Labels: pull-request-available
>
> After [HDDS-8665|https://issues.apache.org/jira/browse/HDDS-8665], there is a possibility that [snapshot cache|https://github.com/apache/ozone/pull/5201/files#diff-a424f5d3db1b2b8c0ffede0b757478c8ab646ea7f7990fd13f36f0346e6a73e0R102] gets updated but [snapshot chain update|https://github.com/apache/ozone/pull/5201/files#diff-a424f5d3db1b2b8c0ffede0b757478c8ab646ea7f7990fd13f36f0346e6a73e0R104] fails and leave it in a situation that snapshot's previous snapshot is pointing to something which doesn't exist or order is messed.
> We need to revisit this and see if there is any race condition issue in snapshot purge.
> One possible solution is, snapshot purge should be single snapshot purge request instead of batch request.
> Other thing is we may need locking in snapshot purge request handler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org