You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2023/11/29 21:42:38 UTC

(spark) branch master updated: [SPARK-46133][CORE][DOCS] Make `ShuffleWriteProcessor.write` method description up-to-date

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new c6793fd4847 [SPARK-46133][CORE][DOCS] Make `ShuffleWriteProcessor.write` method description up-to-date
c6793fd4847 is described below

commit c6793fd484756d6eabf7ea8bf9ae665e361fc95b
Author: zwangsheng <bi...@apache.org>
AuthorDate: Wed Nov 29 13:42:26 2023 -0800

    [SPARK-46133][CORE][DOCS] Make `ShuffleWriteProcessor.write` method description up-to-date
    
    ### What changes were proposed in this pull request?
    
    Modify comment for `ShuffleWriteProcessor.write`
    
    ### Why are the changes needed?
    
    After [SPARK-44605](https://github.com/apache/spark/pull/42234), we move `rdd.iterator(partition, context)` from `ShuffleWriteProcessor#write` to `ShuffleMapTask#runTask`.
    
    We should modify the comments synchronously.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, make comment right for developers
    
    ### How was this patch tested?
    
    No need
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No
    
    Closes #44054 from zwangsheng/SPARK-46133.
    
    Authored-by: zwangsheng <bi...@apache.org>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 .../main/scala/org/apache/spark/shuffle/ShuffleWriteProcessor.scala    | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/core/src/main/scala/org/apache/spark/shuffle/ShuffleWriteProcessor.scala b/core/src/main/scala/org/apache/spark/shuffle/ShuffleWriteProcessor.scala
index 1ee32b92109..1ab77643c03 100644
--- a/core/src/main/scala/org/apache/spark/shuffle/ShuffleWriteProcessor.scala
+++ b/core/src/main/scala/org/apache/spark/shuffle/ShuffleWriteProcessor.scala
@@ -37,8 +37,7 @@ private[spark] class ShuffleWriteProcessor extends Serializable with Logging {
 
   /**
    * The write process for particular partition, it controls the life circle of [[ShuffleWriter]]
-   * get from [[ShuffleManager]] and triggers rdd compute, finally return the [[MapStatus]] for
-   * this task.
+   * get from [[ShuffleManager]] finally return the [[MapStatus]] for this task.
    */
   def write(
       inputs: Iterator[_],


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org