You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "LinMingQiang (via GitHub)" <gi...@apache.org> on 2024/09/13 10:52:42 UTC
[PR] [FLINK-36276] Fix the description of MySqlDataSourceOptions.`scan.sta… [flink-cdc]
LinMingQiang opened a new pull request, #3606:
URL: https://github.com/apache/flink-cdc/pull/3606
…rtup.mode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36276] Fix the description of MySqlDataSourceOptions.`scan.sta… [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on PR #3606:
URL: https://github.com/apache/flink-cdc/pull/3606#issuecomment-2363847956
Could @ruanhang1993 please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36276] Fix the description of MySqlDataSourceOptions.`scan.sta… [flink-cdc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3606:
URL: https://github.com/apache/flink-cdc/pull/3606#issuecomment-2555984996
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36276] Fix the description of MySqlDataSourceOptions.`scan.sta… [flink-cdc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3606: [FLINK-36276] Fix the description of MySqlDataSourceOptions.`scan.sta…
URL: https://github.com/apache/flink-cdc/pull/3606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36276] Fix the description of MySqlDataSourceOptions.`scan.sta… [flink-cdc]
Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #3606:
URL: https://github.com/apache/flink-cdc/pull/3606#issuecomment-2363810910
@yuxiqian Can you help me merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36276] Fix the description of MySqlDataSourceOptions.`scan.sta… [flink-cdc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3606:
URL: https://github.com/apache/flink-cdc/pull/3606#issuecomment-2487014101
This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36276] Fix the description of MySqlDataSourceOptions.`scan.sta… [flink-cdc]
Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on code in PR #3606:
URL: https://github.com/apache/flink-cdc/pull/3606#discussion_r1759636938
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java:
##########
@@ -126,8 +126,8 @@ public class MySqlDataSourceOptions {
.defaultValue("initial")
.withDescription(
"Optional startup mode for MySQL CDC consumer, valid enumerations are "
- + "\"initial\", \"earliest-offset\", \"latest-offset\", \"timestamp\"\n"
- + "or \"specific-offset\"");
+ + "\"initial\", \"earliest-offset\", \"latest-offset\", \"timestamp\", \"specific-offset\"\n,"
+ + " or \"snapshot\"");
Review Comment:
resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36276] Fix the description of MySqlDataSourceOptions.`scan.sta… [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on code in PR #3606:
URL: https://github.com/apache/flink-cdc/pull/3606#discussion_r1759631035
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java:
##########
@@ -126,8 +126,8 @@ public class MySqlDataSourceOptions {
.defaultValue("initial")
.withDescription(
"Optional startup mode for MySQL CDC consumer, valid enumerations are "
- + "\"initial\", \"earliest-offset\", \"latest-offset\", \"timestamp\"\n"
- + "or \"specific-offset\"");
+ + "\"initial\", \"earliest-offset\", \"latest-offset\", \"timestamp\", \"specific-offset\"\n,"
+ + " or \"snapshot\"");
Review Comment:
Seems `\n` here isn't necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org