You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2025/06/19 00:50:04 UTC
[PR] HDDS-13294. Remove the Table.close() method. [ozone]
szetszwo opened a new pull request, #8658:
URL: https://github.com/apache/ozone/pull/8658
## What changes were proposed in this pull request?
All the implementations of the Table.close() method are noop. We should remove it.
The patch of this PR is quite big due to the try-with-resource change for auto-closing Table.
## What is the link to the Apache JIRA
HDDS-13294
## How was this patch tested?
By existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13294. Remove the Table.close() method. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #8658:
URL: https://github.com/apache/ozone/pull/8658#issuecomment-2992631653
Thanks @sarvekshayr and @adoroszlai for reviewing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13294. Remove the Table.close() method. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #8658:
URL: https://github.com/apache/ozone/pull/8658#discussion_r2159112169
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateManagerImpl.java:
##########
@@ -307,7 +307,6 @@ public void close() throws Exception {
lock.writeLock().lock();
try {
if (pipelineStore != null) {
- pipelineStore.close();
pipelineStore = null;
}
} catch (Exception ex) {
Review Comment:
nit: `try-catch` and `if` no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13294. Remove the Table.close() method. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #8658:
URL: https://github.com/apache/ozone/pull/8658#discussion_r2159443394
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateManagerImpl.java:
##########
@@ -307,7 +307,6 @@ public void close() throws Exception {
lock.writeLock().lock();
try {
if (pipelineStore != null) {
- pipelineStore.close();
pipelineStore = null;
}
} catch (Exception ex) {
Review Comment:
I actually want to remove the close() method. Unfortunately, it is not easy to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13294. Remove the Table.close() method. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #8658:
URL: https://github.com/apache/ozone/pull/8658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org