[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2914: [UDF] Fix bug that UDF can't handle constant null value

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #2914: [UDF] Fix bug that UDF can't handle constant null value
URL: https://github.com/apache/incubator-doris/pull/2914#discussion_r379898235
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java
 ##########
 @@ -144,15 +145,6 @@ private synchronized void registerFunctions() {
             }
         }
         this.functions = mapBuilder.build();
-
-        // Functions that need to handle null.
-        ImmutableSet.Builder<String> setBuilder =
-                new ImmutableSet.Builder<String>();
-        setBuilder.add("if");
-        setBuilder.add("hll_hash");
-        setBuilder.add("concat_ws");
-        setBuilder.add("ifnull");
-        this.nonNullResultWithNullParamFunctions = setBuilder.build();
 
 Review comment:
   Why move this to `gensrc/script/doris_builtins_functions.py`?  what's the advantage?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org