[GitHub] [spark] c21 commented on a change in pull request #35038: [SPARK-37728][SQL][3.2] Reading nested columns with ORC vectorized reader can cause ArrayIndexOutOfBoundsException

[GitBox <gi...@apache.org>]

c21 commented on a change in pull request #35038:
URL: https://github.com/apache/spark/pull/35038#discussion_r776614195



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
##########
@@ -644,6 +645,28 @@ class OrcSourceSuite extends OrcSuite with SharedSparkSession {
     }
   }
 
+  test("SPARK-37728: Reading nested columns with ORC vectorized reader should not " +

Review comment:
       Yeah I confirm we need to create unit test in `OrcQuerySuite.scala` instead. Just for context, I moved the unit test from `OrcSourceSuite` to `OrcQuerySuite` when adding support for DSv2 - https://github.com/apache/spark/pull/33842 . Thanks for @dongjoon-hyun pointing it out.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org