Re: Struts Validator Javascript

[Sgarlata Matt <sg...@bah.com>]

I like the concept of the validator, but personally I don't have a lot of
confidence in it.  The second thing I tried to do with it was use the
inRange (or whatever) test, and it didn't work.  I use it server-side and
only for required fields.

Matt
----- Original Message ----- 
From: "Erez Efrati" <er...@netmedia.net.il>
To: "'Struts Users Mailing List'" <st...@jakarta.apache.org>
Sent: Sunday, August 10, 2003 12:28 PM
Subject: Struts Validator Javascript


> Working with the validator I found that the client-side javascript code
> automatically generated by the validator tag does not handle correctly
> or at all fields that are radio group , checkbox group or any other type
> of group that exist.
> I have posted few times on that but no response. After that I went and
> fixed the javascript code to do it correctly in the validateRequired()
> for instance. I am just wondering, am I the only one to use the client
> side validator avascript? Am I so special :) ? Or everyone else is doing
> it differently?
> I would appreciate any remark.
>
> Erez
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-user-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: struts-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-user-help@jakarta.apache.org

Re: Struts Validator Javascript

["Craig R. McClanahan" <cr...@apache.org>]

On Sun, 10 Aug 2003, Adam Hardy wrote:

> Date: Sun, 10 Aug 2003 18:41:32 +0200
> From: Adam Hardy <ah...@cyberspaceroad.com>
> Reply-To: Struts Users Mailing List <st...@jakarta.apache.org>
> To: Struts Users Mailing List <st...@jakarta.apache.org>
> Subject: Re: Struts Validator Javascript
>
> Sgarlata Matt wrote:
> > I like the concept of the validator, but personally I don't have a lot of
> > confidence in it.
>
> that's a bit harsh. I think as long as you know what it does and doesn't
> do, there's every reason to have confidence in it. It's an excellent
> package that will benefit even more when people use it and reports bugs
>   or vote for existing ones or even submit patches in bugzilla :O
>
> I sense an opportunity to share something I got from the Ant mailing
> list recently (struts gurus feel free to slap me down if the same sort
> of thing doesn't apply to struts) :
>
>
> (1) open an enhancement request in bugzilla and attach your patch.  If
>      you just send it to the list it could get lost over time.
>
> (2) send a mail to dev@ant explaining why you think the enhancement is
>      worth it.
>

For us, it is struts-dev@jakarta.apache.org of course.

> (3) send a mail to user@ant so that the people who share your opinion
>      can go to the enhancement request and vote for it.
>

Lobbying on struts-user@jakarta.apache.org is perfectly legitimate, too
:-).

> (4) be persistent.  It is often the case that committers have a lot of
>      time for Ant development in one week and almost none in the next.
>      This could mean you'll need to redo (2).
>

Exactly the same overall advice applies here, with only one wrinkle --
Struts relies on a lot of functionality imported from the Jakarta Commons
libraries (Validator being one of them), so it might end up being the case
that the enhancement request or bug report should really be filed there
instead of against Struts.  I wouldn't worry overmuch about getting it in
the right place, though -- there's lots of committers that are common to
both, and will help recategorize bug reports and enhancement requests as
needed.

One additonal tweak we've been using in Struts is that a bug report or
enhancement request that has a patch included (as an enhancement) should
have "PatchAvailable" added in the "Keywords" field, to make it easier for
committers to find them.

Craig McClanahan


---------------------------------------------------------------------
To unsubscribe, e-mail: struts-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-user-help@jakarta.apache.org

RE: Struts Validator Javascript

[David Graham <gr...@yahoo.com>]

> Keep investigating the problem. If you can come up with new information
> or a
> patch, then that will serve as a much more useful reminder than just
> repeating yourself.

I couldn't agree more with this statement.  Many reported bugs are poorly
described and just left in bugzilla for someone else to figure out. 
Continuing to pursue the issue and providing patches, ideas, or just more
information is critical to the bug getting fixed.

David

> 
> Steve
> 
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-user-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-user-help@jakarta.apache.org
> >
> >
> >
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-user-help@jakarta.apache.org
> 


__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-user-help@jakarta.apache.org

RE: Struts Validator Javascript

[Steve Raeburn <sr...@apache.org>]

> -----Original Message-----
> From: Adam Hardy [mailto:ahardy.struts@cyberspaceroad.com]
> Sent: August 10, 2003 9:42 AM
> To: Struts Users Mailing List
> Subject: Re: Struts Validator Javascript
>
>
> Sgarlata Matt wrote:
> > I like the concept of the validator, but personally I don't
> have a lot of
> > confidence in it.
>
> that's a bit harsh. I think as long as you know what it does and doesn't
> do, there's every reason to have confidence in it. It's an excellent
> package that will benefit even more when people use it and reports bugs
>   or vote for existing ones or even submit patches in bugzilla :O
>
> I sense an opportunity to share something I got from the Ant mailing
> list recently (struts gurus feel free to slap me down if the same sort
> of thing doesn't apply to struts) :
>

Can I also suggest:
  (0) make *sure* it's a bug before you post a bug report.

If you don't *know* that what you're experiencing is a *Struts* bug then the
correct place to explore the problem is on the struts-user list. If what
you're asking for is really an enhancement then mark it as such in Bugzilla.

>
> (1) open an enhancement request in bugzilla and attach your patch.  If
>      you just send it to the list it could get lost over time.
>
> (2) send a mail to dev@ant explaining why you think the enhancement is
>      worth it.

Bugzilla reports get sent to the dev list so you don't need to duplicate
that. Committers are also pretty active on the user list ;-)

>
> (3) send a mail to user@ant so that the people who share your opinion
>      can go to the enhancement request and vote for it.
>
> (4) be persistent.  It is often the case that committers have a lot of
>      time for Ant development in one week and almost none in the next.
>      This could mean you'll need to redo (2).

I would replace (4) with be patient. If you've opened a Bugzilla report then
it *will* get reviewed. But time is limited and certain issues will be dealt
with more quickly. Straight-forward items and serious items tend to get
closed more quickly, with those falling into the not serious, but not
trival, taking a little longer.

Keep investigating the problem. If you can come up with new information or a
patch, then that will serve as a much more useful reminder than just
repeating yourself.

Steve

>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-user-help@jakarta.apache.org
>
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: struts-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-user-help@jakarta.apache.org

Re: Struts Validator Javascript

[Adam Hardy <ah...@cyberspaceroad.com>]

Sgarlata Matt wrote:
> I like the concept of the validator, but personally I don't have a lot of
> confidence in it.  

that's a bit harsh. I think as long as you know what it does and doesn't 
do, there's every reason to have confidence in it. It's an excellent 
package that will benefit even more when people use it and reports bugs 
  or vote for existing ones or even submit patches in bugzilla :O

I sense an opportunity to share something I got from the Ant mailing 
list recently (struts gurus feel free to slap me down if the same sort 
of thing doesn't apply to struts) :


(1) open an enhancement request in bugzilla and attach your patch.  If
     you just send it to the list it could get lost over time.

(2) send a mail to dev@ant explaining why you think the enhancement is
     worth it.

(3) send a mail to user@ant so that the people who share your opinion
     can go to the enhancement request and vote for it.

(4) be persistent.  It is often the case that committers have a lot of
     time for Ant development in one week and almost none in the next.
     This could mean you'll need to redo (2).


---------------------------------------------------------------------
To unsubscribe, e-mail: struts-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-user-help@jakarta.apache.org