You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/20 05:02:49 UTC

[GitHub] [skywalking-java] hutaishi commented on pull request #162: [Feature] [ShenYu](#8869)

hutaishi commented on PR #162:
URL: https://github.com/apache/skywalking-java/pull/162#issuecomment-1103473874

   > 2 questions
   > 
   > 1. Which parts are pure Dubbo plugin enhancement? Tbgis part shoud be in another PR
   > 2. Why you need a snapshot continue inside Dubbo plugin?You could use a local span to continue in Shenyu. Binding 2 plugins with a context key is not recommended, only when has to be done, I feel this is not the case.
   
   Hello, I'd like to ask the second question. I tried to use localspan, but due to cross threading, abstracttracercontext is empty when closing localspan.
   
   ![image](https://user-images.githubusercontent.com/12478263/164154012-2c8d2721-76ce-4cbe-83d4-b5e43a9b1b12.png)
   
   
   
   
   ![image](https://user-images.githubusercontent.com/12478263/164153884-4f82da37-b898-4ef2-87fe-a52f6edf3290.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org