You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/31 02:08:40 UTC
[GitHub] [spark] williamhyun opened a new pull request #36017: [SPARK-38706][CORE] Use URI in FallbackStorage.copy
williamhyun opened a new pull request #36017:
URL: https://github.com/apache/spark/pull/36017
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #36017: [SPARK-38706][CORE] Use URI in `FallbackStorage.copy`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #36017:
URL: https://github.com/apache/spark/pull/36017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36017: [SPARK-38706][CORE] Use URI in `FallbackStorage.copy`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #36017:
URL: https://github.com/apache/spark/pull/36017#issuecomment-1084015506
I also verified that this is the last instance because RocksDBFileManager is already using `URI` too.
```
$ git grep -C1 copyFromLocalFile | grep -v test
core/src/main/scala/org/apache/spark/storage/FallbackStorage.scala- val hash = JavaUtils.nonNegativeHash(indexFile.getName)
core/src/main/scala/org/apache/spark/storage/FallbackStorage.scala: fallbackFileSystem.copyFromLocalFile(
core/src/main/scala/org/apache/spark/storage/FallbackStorage.scala- new Path(indexFile.getAbsolutePath),
--
core/src/main/scala/org/apache/spark/storage/FallbackStorage.scala- val hash = JavaUtils.nonNegativeHash(dataFile.getName)
core/src/main/scala/org/apache/spark/storage/FallbackStorage.scala: fallbackFileSystem.copyFromLocalFile(
core/src/main/scala/org/apache/spark/storage/FallbackStorage.scala- new Path(dataFile.getAbsolutePath),
--
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala- try {
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala: fs.copyFromLocalFile(delSrc, overwrite, src, dest)
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala- } catch {
--
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala- val dfsFile = dfsFilePath(dfsFileName)
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala: // Note: The implementation of copyFromLocalFile() closes the output stream when there is
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala- // any exception while copying. So this may generate partial files on DFS. But that is
--
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala- // not going to be used at all. Eventually these files should get cleared.
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala: fs.copyFromLocalFile(
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala- new Path(localFile.getAbsoluteFile.toURI), dfsFile)
--
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36017: [SPARK-38706][CORE] Use URI in `FallbackStorage.copy`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #36017:
URL: https://github.com/apache/spark/pull/36017#issuecomment-1084055589
All tests passed. Merged to master/3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org