You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kannon92 (via GitHub)" <gi...@apache.org> on 2023/07/20 14:09:07 UTC
[GitHub] [airflow] kannon92 opened a new pull request, #32719: add a patch fix for reconnecting on read_pods for caes where k8 auth …
kannon92 opened a new pull request, #32719:
URL: https://github.com/apache/airflow/pull/32719
closes: #32718
I have a patch from my client that they use to reconnect pods with KPO in the case of an expiring token.
Opening this up as is and happy to discuss better ideas!
Essentially we want to reconnect/reauthenticate on read_pods as we found that when the token expires our tasks start getting 401 errors.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kannon92 commented on pull request #32719: Reconnect on read_pods when k8s auth fails
Posted by "kannon92 (via GitHub)" <gi...@apache.org>.
kannon92 commented on PR #32719:
URL: https://github.com/apache/airflow/pull/32719#issuecomment-1656213528
@hussein-awala or @jedcunningham can I get CI approval to run the tests? I think I took some merges with the kubernetes cleanup and it caused some extra issues. I ran `precommit` and breeze and I think it should be good again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #32719: Reconnect on read_pods when k8s auth fails
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #32719: Reconnect on read_pods when k8s auth fails
URL: https://github.com/apache/airflow/pull/32719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #32719: Reconnect on read_pods when k8s auth fails
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #32719:
URL: https://github.com/apache/airflow/pull/32719#discussion_r1277983204
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -353,7 +354,7 @@ def __init__(
self.volumes = [convert_volume(volume) for volume in volumes] if volumes else []
self.secrets = secrets or []
self.in_cluster = in_cluster
- self.cluster_context = cluster_context
+ self.cluster_context = cluster_context or ""
Review Comment:
> You should rather do:
self.cluster_context = cluster_context if cluster_context else ""
No need, the syntax is correct:
```python
>>> False or ""
''
>>> None or ""
''
>>> "something" or ""
'something'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on a diff in pull request #32719: Reconnect on read_pods when k8s auth fails
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #32719:
URL: https://github.com/apache/airflow/pull/32719#discussion_r1275173011
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -353,7 +354,7 @@ def __init__(
self.volumes = [convert_volume(volume) for volume in volumes] if volumes else []
self.secrets = secrets or []
self.in_cluster = in_cluster
- self.cluster_context = cluster_context
+ self.cluster_context = cluster_context or ""
Review Comment:
Is this the right syntax? It will always evaluate to cluster_context.
Python will perform an 'or' operation here.
You should rather do:
`self.cluster_context = cluster_context if cluster_context else ""`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kannon92 commented on a diff in pull request #32719: Reconnect on read_pods when k8s auth fails
Posted by "kannon92 (via GitHub)" <gi...@apache.org>.
kannon92 commented on code in PR #32719:
URL: https://github.com/apache/airflow/pull/32719#discussion_r1275429421
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -353,7 +354,7 @@ def __init__(
self.volumes = [convert_volume(volume) for volume in volumes] if volumes else []
self.secrets = secrets or []
self.in_cluster = in_cluster
- self.cluster_context = cluster_context
+ self.cluster_context = cluster_context or ""
Review Comment:
I'm a pretty new python dev but I took this as an example throughout the constructor of this function.
```
self.secrets = secrets or []
```
Reading about this here https://realpython.com/python-or-operator/#how-the-python-or-operator-works it seems that it would set self.cluster_context to be cluster_context if it is not None. It is short hand for what you have there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #32719: Reconnect on read_pods when k8s auth fails
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32719:
URL: https://github.com/apache/airflow/pull/32719#issuecomment-1714777665
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #32719: add a patch fix for reconnecting on read_pods for caes where k8 auth …
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #32719:
URL: https://github.com/apache/airflow/pull/32719#issuecomment-1643997194
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org