You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/03 07:28:22 UTC

[GitHub] [tvm] masahi edited a comment on pull request #7892: [WIP][Runtime]Pipeline Executor For Compute graph pipeline

masahi edited a comment on pull request #7892:
URL: https://github.com/apache/tvm/pull/7892#issuecomment-912317834


   Thanks @huajsj. Please respect our coding style and standard good programming practices:
   * For C++ code: Variable names should be `snake_case` and function / class names should be `CamelCase`
   * Do not use `using namespace` without good reason
   * Do not introduce complicated typedef like `typedef unordered_map<int, unordered_map<int, unordered_map<int, string>>> PIPELINE_CONF;`. Introducing a class should be more readable. 
   * Do not use weird type name like `RUNTIME_PIPELINE_OUTPUT_CONF`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org