[GitHub] [nuttx] dvosahlik commented on a diff in pull request #8152: Tm4 c1294 can char dev

[GitBox <gi...@apache.org>]

dvosahlik commented on code in PR #8152:
URL: https://github.com/apache/nuttx/pull/8152#discussion_r1071920102


##########
boards/arm/tiva/tm4c1294-launchpad/src/tm4c1294-launchpad.h:
##########
@@ -77,6 +77,9 @@
 #  undef HAVE_I2CTOOL
 #endif
 
+/* Define the procfs mounting point */
+#define TIVA_PROCFS_MOUNTPOINT "/proc"

Review Comment:
   Done in [997e60a](https://github.com/apache/nuttx/pull/8152/commits/997e60aaddec0694f4ca171eeeae0adc57b66ab3)



##########
boards/arm/tiva/tm4c1294-launchpad/Kconfig:
##########
@@ -72,4 +72,46 @@ config TM4C1294_LAUNCHPAD_TIMER_ALTCLK
 
 endif # TM4C1294_LAUNCHPAD_TIMER
 endif # TIVA_TIMER32_PERIODIC
+config TM4C1294_LAUNCHPAD_JUMPERS_CAN
+	bool "Use CAN jumpers configuration"
+	default n
+	select TIVA_UART2
+	---help---
+		If set, Nuttx will assume the jumpers JP4 and JP5 are set in CAN configuration.

Review Comment:
   Done in [997e60a](https://github.com/apache/nuttx/pull/8152/commits/997e60aaddec0694f4ca171eeeae0adc57b66ab3)



##########
boards/arm/tiva/tm4c1294-launchpad/src/tm4c_can.c:
##########
@@ -0,0 +1,148 @@
+/****************************************************************************
+ * boards/arm/tiva/tm4c1294-launchpad/src/tm4c_can.c
+ * Based heavily on stm32_can.c from the boards directory.
+ *
+ * Redistribution and use in source and binary forms, with or without

Review Comment:
   Done in [997e60a](https://github.com/apache/nuttx/pull/8152/commits/997e60aaddec0694f4ca171eeeae0adc57b66ab3)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org