You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2009/03/06 01:47:56 UTC
[jira] Created: (HADOOP-5417) IPC client drops interrupted
exceptions
IPC client drops interrupted exceptions
---------------------------------------
Key: HADOOP-5417
URL: https://issues.apache.org/jira/browse/HADOOP-5417
Project: Hadoop Core
Issue Type: Bug
Components: ipc
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Priority: Blocker
The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Sameer Paranjpye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sameer Paranjpye updated HADOOP-5417:
-------------------------------------
Fix Version/s: 0.21.0
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-5417:
----------------------------------
Status: Patch Available (was: Open)
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Attachments: h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683646#action_12683646 ]
Owen O'Malley commented on HADOOP-5417:
---------------------------------------
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: h5417.patch, h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-5417:
----------------------------------
Fix Version/s: (was: 0.21.0)
0.20.0
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: h5417.patch, h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680086#action_12680086 ]
Hadoop QA commented on HADOOP-5417:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401582/h5417.patch
against trunk revision 751463.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/56/console
This message is automatically generated.
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Attachments: h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683999#action_12683999 ]
Hudson commented on HADOOP-5417:
--------------------------------
Integrated in Hadoop-trunk #785 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/785/])
. Don't ignore InterruptedExceptions that happen when calling
into rpc. (omalley)
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: h5417.patch, h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-5417:
----------------------------------
Attachment: h5417.patch
This patch removes the needless catch.
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Attachments: h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-5417:
----------------------------------
Attachment: h5417.patch
*Sigh* To throw InterruptedException, we need to declare it in the protocol interfaces on all of the methods. That is the right fix, but here is a lower cost solution that won't require as much code change, but with increased latency.
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Attachments: h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683749#action_12683749 ]
Chris Douglas commented on HADOOP-5417:
---------------------------------------
+1
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: h5417.patch, h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-5417:
----------------------------------
Status: Open (was: Patch Available)
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: h5417.patch, h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-5417:
----------------------------------
Status: Patch Available (was: Open)
resubmitting to hudson
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: h5417.patch, h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-5417:
----------------------------------
Attachment: h5417.patch
Updated to current trunk.
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: h5417.patch, h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683650#action_12683650 ]
Hadoop QA commented on HADOOP-5417:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12402450/h5417.patch
against trunk revision 756107.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/109/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/109/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/109/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/109/console
This message is automatically generated.
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: h5417.patch, h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5417) IPC client drops interrupted
exceptions
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-5417:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this.
> IPC client drops interrupted exceptions
> ---------------------------------------
>
> Key: HADOOP-5417
> URL: https://issues.apache.org/jira/browse/HADOOP-5417
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: h5417.patch, h5417.patch, h5417.patch
>
>
> The IPC client needless drops InterruptedException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.