You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/02/21 07:27:02 UTC
Review Request 56866: RANGER-1399:Do some code improvement in Java
method SolrUtil.searchResources
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56866/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1399
https://issues.apache.org/jira/browse/RANGER-1399
Repository: ranger
Description
-------
#Solution:
Do some code improvement in Java method SolrUtil.searchResources and
some related in SolrAccessAuditsService.searchXAccessAudits.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
Diff: https://reviews.apache.org/r/56866/diff/
Testing
-------
#Test Result:
1.Start Ranger-Admin success with using solr for audit
2.Search success in Audit Access WebPage
Thanks,
Qiang Zhang
Re: Review Request 56866: RANGER-1399:Do some code improvement in Java
method SolrUtil.searchResources
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56866/#review167030
-----------------------------------------------------------
The patch of the RANGER-1399 was not submitted to the ranger master repository. So I reopened it. Please resolved the issue first. After the patch was submitted to the ranger master repository, I'll close it again. Thanks.
- Qiang Zhang
On \u4e8c\u6708 21, 2017, 9:59 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56866/
> -----------------------------------------------------------
>
> (Updated \u4e8c\u6708 21, 2017, 9:59 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1399
> https://issues.apache.org/jira/browse/RANGER-1399
>
>
> Repository: ranger
>
>
> Description
> -------
>
> #Solution:
> Do some code improvement in Java method SolrUtil.searchResources and
> some related in SolrAccessAuditsService.searchXAccessAudits.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
> security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
>
> Diff: https://reviews.apache.org/r/56866/diff/
>
>
> Testing
> -------
>
> #Test Result:
> 1.Start Ranger-Admin success with using solr for audit
> 2.Search success in Audit Access WebPage
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 56866: RANGER-1399:Do some code improvement in Java
method SolrUtil.searchResources
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56866/#review166847
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On Feb. 21, 2017, 9:59 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56866/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 9:59 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1399
> https://issues.apache.org/jira/browse/RANGER-1399
>
>
> Repository: ranger
>
>
> Description
> -------
>
> #Solution:
> Do some code improvement in Java method SolrUtil.searchResources and
> some related in SolrAccessAuditsService.searchXAccessAudits.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
> security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
>
> Diff: https://reviews.apache.org/r/56866/diff/
>
>
> Testing
> -------
>
> #Test Result:
> 1.Start Ranger-Admin success with using solr for audit
> 2.Search success in Audit Access WebPage
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 56866: RANGER-1399:Do some code improvement in Java
method SolrUtil.searchResources
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56866/
-----------------------------------------------------------
(Updated \u4e8c\u6708 21, 2017, 9:59 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Change the error message "Search field is not of java object instanceof Date" to "Search field is not a Java Date Object".
Bugs: RANGER-1399
https://issues.apache.org/jira/browse/RANGER-1399
Repository: ranger
Description
-------
#Solution:
Do some code improvement in Java method SolrUtil.searchResources and
some related in SolrAccessAuditsService.searchXAccessAudits.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
Diff: https://reviews.apache.org/r/56866/diff/
Testing
-------
#Test Result:
1.Start Ranger-Admin success with using solr for audit
2.Search success in Audit Access WebPage
Thanks,
Qiang Zhang
Re: Review Request 56866: RANGER-1399:Do some code improvement in Java
method SolrUtil.searchResources
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56866/#review166131
-----------------------------------------------------------
I would change the error message "Search field is not of java object instanceof Date" to "Search field is not a Java Date Object".
- Colm O hEigeartaigh
On Feb. 21, 2017, 7:57 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56866/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 7:57 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1399
> https://issues.apache.org/jira/browse/RANGER-1399
>
>
> Repository: ranger
>
>
> Description
> -------
>
> #Solution:
> Do some code improvement in Java method SolrUtil.searchResources and
> some related in SolrAccessAuditsService.searchXAccessAudits.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
> security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
>
> Diff: https://reviews.apache.org/r/56866/diff/
>
>
> Testing
> -------
>
> #Test Result:
> 1.Start Ranger-Admin success with using solr for audit
> 2.Search success in Audit Access WebPage
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 56866: RANGER-1399:Do some code improvement in Java
method SolrUtil.searchResources
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56866/
-----------------------------------------------------------
(Updated \u4e8c\u6708 21, 2017, 7:57 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1399
https://issues.apache.org/jira/browse/RANGER-1399
Repository: ranger
Description
-------
#Solution:
Do some code improvement in Java method SolrUtil.searchResources and
some related in SolrAccessAuditsService.searchXAccessAudits.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 917c760
security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java a851c3e
Diff: https://reviews.apache.org/r/56866/diff/
Testing
-------
#Test Result:
1.Start Ranger-Admin success with using solr for audit
2.Search success in Audit Access WebPage
Thanks,
Qiang Zhang