You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "YoWuwuuuw (via GitHub)" <gi...@apache.org> on 2025/03/30 10:09:41 UTC
[PR] optimize: seata-server log configuration [incubator-seata]
YoWuwuuuw opened a new pull request, #7259:
URL: https://github.com/apache/incubator-seata/pull/7259
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
Optimisation Points:
If you need to collect seata-server logs to Kafka and logstash, you need to modify the logback-spring.xml configuration file (uncomment the corresponding appender), and you need to revise the specific configuration of Kafka-appender by revising kafka-appender.xml and application.yml.
It's a hassle.
Optimisation Scheme: Establish SpringProperty mapping
The configuration of open Kafka, logstash and metric's appender will be transferred to application.yml.
Transfer the specific configuration of Kafka to application.yml.
About dynamic updates to configuration changes
in logback-spring.xml,
`configuration scan="true" scanPeriod="60 seconds" debug="false"`
The configuration is scaned every minute, so if you introduce a configuration center to change the yml configuration, it is visible to logback originally.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
#4648
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: seata-server log configuration [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly merged PR #7259:
URL: https://github.com/apache/incubator-seata/pull/7259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: seata-server log configuration [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7259:
URL: https://github.com/apache/incubator-seata/pull/7259#issuecomment-2764533183
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7259?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 54.18%. Comparing base [(`f083840`)](https://app.codecov.io/gh/apache/incubator-seata/commit/f083840aebc18a4d07dad84ce54aeac81b94c467?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6cb760b`)](https://app.codecov.io/gh/apache/incubator-seata/commit/6cb760bf1c222773a9cdbe27d0aacf68732b1787?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7259 +/- ##
=========================================
Coverage 54.17% 54.18%
- Complexity 7257 7261 +4
=========================================
Files 1178 1178
Lines 41952 41952
Branches 4923 4923
=========================================
+ Hits 22729 22732 +3
- Misses 17069 17071 +2
+ Partials 2154 2149 -5
```
[see 6 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7259/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org