You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/02 21:48:37 UTC

[GitHub] [hbase] saintstack commented on issue #966: HBASE-23620 KeyPrefixRegionSplitPolicy may cause split to fail when s…

saintstack commented on issue #966: HBASE-23620 KeyPrefixRegionSplitPolicy may cause split to fail when s…
URL: https://github.com/apache/hbase/pull/966#issuecomment-570363974
 
 
   On the one hand, this fix is good; it caters for an issue the operator did not foresee. On the otherhand, as per @Apache9 , it does the 'fix' in violation of this KPRSP. Minimally I would think the class comment would change and we'd log the policy violations. Better would be a new policy that subclasses this one that is explicit that it will violate KPRSP if it fails to find an obliging split?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services