[GitHub] [druid] clintropolis commented on a change in pull request #11756: Add sql query id to response header for failed sql query

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #11756:
URL: https://github.com/apache/druid/pull/11756#discussion_r718988827



##########
File path: sql/src/test/java/org/apache/druid/sql/http/SqlResourceTest.java
##########
@@ -973,6 +975,41 @@ public void testUnsupportedQueryThrowsException() throws Exception
     Assert.assertTrue(lifecycleManager.getAll("id").isEmpty());
   }
 
+  @Test
+  public void testErrorResponseReturnSameQueryIdWhenSetInContext() throws Exception
+  {
+    String queryId = "id123";
+    String errorMessage = "This will be support in Druid 9999";
+    SqlQuery badQuery = EasyMock.createMock(SqlQuery.class);
+    EasyMock.expect(badQuery.getQuery()).andReturn("SELECT ANSWER TO LIFE");

Review comment:
       heh, good thing we have until version 9999 to implement this... 😅 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org