You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Alexander Kolbasov <ak...@gmail.com> on 2016/12/03 05:00:11 UTC
Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/
-----------------------------------------------------------
(Updated Dec. 3, 2016, 5 a.m.)
Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Addressed code review comments. Also made main class configurable via SENTRY_MAIN environment variable
Repository: sentry
Description
-------
SENTRY-1525: Provide script to run Sentry directly from the repo
Diffs (updated)
-----
bin/run_sentry.sh PRE-CREATION
Diff: https://reviews.apache.org/r/53872/diff/
Testing
-------
Thanks,
Alexander Kolbasov
Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/#review158051
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On Dec. 3, 2016, 5 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53872/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 5 a.m.)
>
>
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1525: Provide script to run Sentry directly from the repo
>
>
> Diffs
> -----
>
> bin/run_sentry.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53872/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/#review158052
-----------------------------------------------------------
Can we rename the file to say "run_local_sentry" to explictly state it is for developer use rather than getting confused about the use of it.
- Vamsee Yarlagadda
On Dec. 3, 2016, 5 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53872/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 5 a.m.)
>
>
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1525: Provide script to run Sentry directly from the repo
>
>
> Diffs
> -----
>
> bin/run_sentry.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53872/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 53872: SENTRY-1525: Provide script to run Sentry
directly from the repo
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53872/#review158155
-----------------------------------------------------------
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Dec. 3, 2016, 5 a.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53872/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 5 a.m.)
>
>
> Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, kalyan kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1525: Provide script to run Sentry directly from the repo
>
>
> Diffs
> -----
>
> bin/run_sentry.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53872/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Kolbasov
>
>