You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ja...@apache.org on 2026/10/26 15:15:01 UTC
(impala) 02/02: IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
This is an automated email from the ASF dual-hosted git repository.
asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit c580d36e61463f701d30fbccc323db1d1696e22d
Author: jasonmfehr <jf...@cloudera.com>
AuthorDate: Wed Oct 21 15:43:41 2026 -0700
IMPALA-15609: [tools] Devcontainer Upstream Git Repo Incorrect
Modifies the Impala devcontainer container image build to set up a
git remote named "upstream" with a URL of "${GIT_REPO}" which uses
the GIT_REPO container build argument.
Testing accomplished by building new container image and running a
devcontainer using that image.
Change-Id: I7fa0c6c677583a8d1fc1450b4740c186cd06f3dd
Reviewed-on: http://gerrit.cloudera.org:8080/25186
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
.devcontainer-build/Dockerfile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.devcontainer-build/Dockerfile b/.devcontainer-build/Dockerfile
index dbf15dac26..485a100b5b 100644
--- a/.devcontainer-build/Dockerfile
+++ b/.devcontainer-build/Dockerfile
@@ -20,6 +20,7 @@ FROM ubuntu:22.04
ARG GIT_REPO
ARG GIT_BRANCH
ARG GIT_HASH
+ARG GIT_REPO_PREFIX="https://"
LABEL git.repo="${GIT_REPO}"
LABEL git.branch="${GIT_BRANCH}"
LABEL git.hash="${GIT_HASH}"
@@ -166,7 +167,7 @@ RUN echo "y" | sh -c "$(curl -fsSL https://raw.githubusercontent.com/ohmyzsh/ohm
&& git reflog expire --expire=30.days.ago --all \
&& git gc --aggressive --prune=now \
&& for remote in $(git remote); do git remote rm "${remote}"; done \
- && git remote add upstream https://github.com/apache/impala.git \
+ && git remote add upstream "${GIT_REPO_PREFIX}{GIT_REPO}" \
&& rm -f "${USER_HOME}/.gitconfig" \
&& echo "[STATUS] - prepopulating Impala shell virtual environment" \
&& ./bin/impala-shell.sh --version \