[GitHub] [bookkeeper] coolbeevip edited a comment on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests

[GitBox <gi...@apache.org>]

coolbeevip edited a comment on issue #2226: ISSUE-2224: Config ServerConfiguration with setAllowLoopback(true) for Unit Tests
URL: https://github.com/apache/bookkeeper/pull/2226#issuecomment-569412228
 
 
   I found that checking license fails using script check-binary-license. The reason for the failure is that the 3rd party jars list in the LICENSE file does not exist in the lib directory.
   
   e.g.
   
   LICENSE contains the following, but these jars do not exist in bookkeeper-all-4.11.0-SNAPSHOT-bin.tar.gz
   
   ```
   ------------------------------------------------------------------------------------
   The following bundled 3rd party jars are distributed under the
   Apache Software License, Version 2.
   ...
   - lib/io.grpc-grpc-all-1.18.0.jar [45]
   - lib/io.grpc-grpc-auth-1.18.0.jar [45]
   - lib/io.grpc-grpc-context-1.18.0.jar [45]
   - lib/io.grpc-grpc-core-1.18.0.jar [45]
   - lib/io.grpc-grpc-netty-1.18.0.jar [45]
   - lib/io.grpc-grpc-okhttp-1.18.0.jar [45]
   - lib/io.grpc-grpc-protobuf-1.18.0.jar [45]
   - lib/io.grpc-grpc-protobuf-lite-1.18.0.jar [45]
   - lib/io.grpc-grpc-protobuf-nano-1.18.0.jar [45]
   - lib/io.grpc-grpc-stub-1.18.0.jar [45]
   - lib/io.grpc-grpc-testing-1.18.0.jar [45]
   ...
   ```
   
   I compared bookkeeper-all-4.11.0-SNAPSHOT.tar.gz and bookkeeper-server-4.10.0.tar.gz. I found that some jars contained in a no longer exist in bookkeeper-all-4.11.0-SNAPSHOT.tar.gz
   
   If these jars are no longer needed, you need to remove them from LICENSE-all.bin.txt

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services