[jira] [Work logged] (LANG-1519) Add Integer Utils to library

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LANG-1519?focusedWorklogId=423892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-423892 ]

ASF GitHub Bot logged work on LANG-1519:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Apr/20 03:17
            Start Date: 17/Apr/20 03:17
    Worklog Time Spent: 10m 
      Work Description: nnivruth commented on issue #495: LANG-1519 Add zero, positive & negative util methods
URL: https://github.com/apache/commons-lang/pull/495#issuecomment-615014953
 
 
   @garydgregory ,
   Been thinking and trying to make these functions more OO and rely on a single method but seeing some difficulties with type casting (esp for special types of number implementations - BigDecimal, etc), NaNs and custom Number implementations. 
   
   Some examples:
   
   - the isZero() function with the current impl does a direct equality check and returns true when passed with (-0.0d). IMO this is acceptable and correct but with the new impl it'll return false
   
   - the functions isZero(), isPositive(), isNegative() return false for float/double NaNs & vice versa for isNotZero(), isNotPositive(), isNotNegative() but with compare we might have to add special checks for these scenarios
   
   
   your thoughts/inputs on how to proceed?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 423892)
    Time Spent: 5h 20m  (was: 5h 10m)

> Add Integer Utils to library
> ----------------------------
>
>                 Key: LANG-1519
>                 URL: https://issues.apache.org/jira/browse/LANG-1519
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>            Reporter: Nivruth Nandigam
>            Priority: Trivial
>          Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> Create Integer Utils class for useful integer operations and a placeholder for adding more useful/important utility functions
>  
> Pull Request: [https://github.com/apache/commons-lang/pull/495]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)