You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2019/03/18 08:47:57 UTC

[arrow] branch master updated: ARROW-4942: [Ruby] Remove needless omits in tests

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 7b43bcf  ARROW-4942: [Ruby] Remove needless omits in tests
7b43bcf is described below

commit 7b43bcfaad5b8146f54d9975adb9bb8c88fbc60d
Author: Kenta Murata <mr...@mrkn.jp>
AuthorDate: Mon Mar 18 17:47:42 2019 +0900

    ARROW-4942: [Ruby] Remove needless omits in tests
    
    @kou I forgot to remove `omit("Need to add support for NullArrayBuilder")` in the previous pull-request.
    
    Author: Kenta Murata <mr...@mrkn.jp>
    
    Closes #3956 from mrkn/ruby_remove_omits and squashes the following commits:
    
    a3fe8baf <Kenta Murata> Remove needless omits in tests
---
 ruby/red-arrow/test/raw-records/record-batch/test-dense-union-array.rb  | 1 -
 ruby/red-arrow/test/raw-records/record-batch/test-list-array.rb         | 1 -
 ruby/red-arrow/test/raw-records/record-batch/test-sparse-union-array.rb | 1 -
 ruby/red-arrow/test/raw-records/record-batch/test-struct-array.rb       | 1 -
 4 files changed, 4 deletions(-)

diff --git a/ruby/red-arrow/test/raw-records/record-batch/test-dense-union-array.rb b/ruby/red-arrow/test/raw-records/record-batch/test-dense-union-array.rb
index 8fdf02e..3520eba 100644
--- a/ruby/red-arrow/test/raw-records/record-batch/test-dense-union-array.rb
+++ b/ruby/red-arrow/test/raw-records/record-batch/test-dense-union-array.rb
@@ -84,7 +84,6 @@ class RawRecordsRecordBatchDenseUnionArrayTest < Test::Unit::TestCase
   end
 
   test("NullArray") do
-    omit("Need to add support for NullArrayBuilder")
     records = [
       [{"0" => nil}],
       [nil],
diff --git a/ruby/red-arrow/test/raw-records/record-batch/test-list-array.rb b/ruby/red-arrow/test/raw-records/record-batch/test-list-array.rb
index bf1af36..3c4963d 100644
--- a/ruby/red-arrow/test/raw-records/record-batch/test-list-array.rb
+++ b/ruby/red-arrow/test/raw-records/record-batch/test-list-array.rb
@@ -34,7 +34,6 @@ class RawRecordsRecordBatchListArrayTest < Test::Unit::TestCase
   end
 
   test("NullArray") do
-    omit("Need to add support for NullArrayBuilder")
     records = [
       [[nil, nil, nil]],
       [nil],
diff --git a/ruby/red-arrow/test/raw-records/record-batch/test-sparse-union-array.rb b/ruby/red-arrow/test/raw-records/record-batch/test-sparse-union-array.rb
index 3a6191d..f963494 100644
--- a/ruby/red-arrow/test/raw-records/record-batch/test-sparse-union-array.rb
+++ b/ruby/red-arrow/test/raw-records/record-batch/test-sparse-union-array.rb
@@ -72,7 +72,6 @@ class RawRecordsRecordBatchSparseUnionArrayTest < Test::Unit::TestCase
   end
 
   test("NullArray") do
-    omit("Need to add support for NullArrayBuilder")
     records = [
       [{"0" => nil}],
       [nil],
diff --git a/ruby/red-arrow/test/raw-records/record-batch/test-struct-array.rb b/ruby/red-arrow/test/raw-records/record-batch/test-struct-array.rb
index bccd0d9..eba6d29 100644
--- a/ruby/red-arrow/test/raw-records/record-batch/test-struct-array.rb
+++ b/ruby/red-arrow/test/raw-records/record-batch/test-struct-array.rb
@@ -36,7 +36,6 @@ class RawRecordsRecordBatchStructArrayTest < Test::Unit::TestCase
   end
 
   test("NullArray") do
-    omit("Need to add support for NullArrayBuilder")
     records = [
       [{"field" => nil}],
       [nil],