You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/05/01 20:10:45 UTC
[GitHub] [trafficserver] randall opened a new pull request #6733: Various python fixes
randall opened a new pull request #6733:
URL: https://github.com/apache/trafficserver/pull/6733
Fixes found by deepsource.io
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #6733: Various python fixes
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #6733:
URL: https://github.com/apache/trafficserver/pull/6733#issuecomment-648383975
Needed for other CP's.
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on a change in pull request #6733: Various python fixes
Posted by GitBox <gi...@apache.org>.
maskit commented on a change in pull request #6733:
URL: https://github.com/apache/trafficserver/pull/6733#discussion_r419183034
##########
File path: doc/ext/traffic-server.py
##########
@@ -389,7 +389,7 @@ def get_objects(self):
'rev-parse', '--abbrev-ref', 'HEAD'])
-def make_github_link(name, rawtext, text, lineno, inliner, options={}, content=[]):
+def make_github_link(name, rawtext, text, lineno, inliner, options=None, content=None):
Review comment:
Wow, what a crazy design.
https://florimond.dev/blog/articles/2018/08/python-mutable-defaults-are-the-source-of-all-evil/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org