You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/12/10 22:55:41 UTC
[PR] Take fsb null indices [arrow-rs]
alamb opened a new pull request, #8981:
URL: https://github.com/apache/arrow-rs/pull/8981
# Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
- redo of https://github.com/apache/arrow-rs/pull/8948 from @tobixdev
- closes https://github.com/apache/arrow-rs/issues/8947
# Rationale for this change
I messed up @tobixdev 's PR / branch by accident in https://github.com/apache/arrow-rs/pull/8948 and wanted to make sure I didn't lose the code
# What changes are included in this PR?
See https://github.com/apache/arrow-rs/pull/8948
# Are these changes tested?
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
# Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Take fsb null indices [arrow-rs]
Posted by "alamb-ghbot (via GitHub)" <gi...@apache.org>.
alamb-ghbot commented on PR #8981:
URL: https://github.com/apache/arrow-rs/pull/8981#issuecomment-3641958992
🤖 `./gh_compare_arrow.sh` [gh_compare_arrow.sh](https://github.com/alamb/datafusion-benchmarking/blob/main/scripts/gh_compare_arrow.sh) Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing take-fsb-null-indices (885f31e26ec2019132f7b1512b9b3f08dc873c1a) to 1c90efe717c1a2f99a0a97d6e9c93cd913eaca3c [diff](https://github.com/apache/arrow-rs/compare/1c90efe717c1a2f99a0a97d6e9c93cd913eaca3c..885f31e26ec2019132f7b1512b9b3f08dc873c1a)
BENCH_NAME=take_kernels
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental --bench take_kernels
BENCH_FILTER=
BENCH_BRANCH_NAME=take-fsb-null-indices
Results will be posted here when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Take fsb null indices [arrow-rs]
Posted by "alamb-ghbot (via GitHub)" <gi...@apache.org>.
alamb-ghbot commented on PR #8981:
URL: https://github.com/apache/arrow-rs/pull/8981#issuecomment-3642001699
🤖: Benchmark completed
<details><summary>Details</summary>
<p>
```
group main take-fsb-null-indices
----- ---- ---------------------
take bool 1024 1.00 1337.3±30.18ns ? ?/sec 1.00 1338.1±12.91ns ? ?/sec
take bool 512 1.00 732.2±11.16ns ? ?/sec 1.00 732.9±10.10ns ? ?/sec
take bool null indices 1024 1.02 1654.5±24.98ns ? ?/sec 1.00 1614.9±37.41ns ? ?/sec
take bool null values 1024 1.00 2.6±0.09µs ? ?/sec 1.00 2.6±0.02µs ? ?/sec
take bool null values null indices 1024 1.00 3.2±0.06µs ? ?/sec 1.02 3.3±0.02µs ? ?/sec
take check bounds i32 1024 1.00 1623.5±17.69ns ? ?/sec 1.00 1624.0±25.86ns ? ?/sec
take check bounds i32 512 1.00 808.4±3.34ns ? ?/sec 1.01 813.4±2.59ns ? ?/sec
take i32 1024 1.00 710.9±10.84ns ? ?/sec 1.01 715.3±6.54ns ? ?/sec
take i32 512 1.00 388.0±3.42ns ? ?/sec 1.09 424.3±14.23ns ? ?/sec
take i32 null indices 1024 1.00 993.0±6.86ns ? ?/sec 1.00 995.6±10.40ns ? ?/sec
take i32 null values 1024 1.01 2.1±0.02µs ? ?/sec 1.00 2.0±0.02µs ? ?/sec
take i32 null values null indices 1024 1.01 2.6±0.03µs ? ?/sec 1.00 2.6±0.07µs ? ?/sec
take primitive fsb value len: 12, indices: 1024 2.25 8.4±0.07µs ? ?/sec 1.00 3.7±0.06µs ? ?/sec
take primitive fsb value len: 12, null values, indices: 1024 1.68 8.4±0.08µs ? ?/sec 1.00 5.0±0.01µs ? ?/sec
take primitive run logical len: 1024, physical len: 512, indices: 1024 1.00 20.6±0.13µs ? ?/sec 1.00 20.5±0.16µs ? ?/sec
take str 1024 1.00 10.9±0.04µs ? ?/sec 1.00 10.9±0.12µs ? ?/sec
take str 512 1.01 5.4±0.04µs ? ?/sec 1.00 5.3±0.04µs ? ?/sec
take str null indices 1024 1.01 6.9±0.05µs ? ?/sec 1.00 6.8±0.11µs ? ?/sec
take str null indices 512 1.04 3.4±0.02µs ? ?/sec 1.00 3.3±0.04µs ? ?/sec
take str null values 1024 1.00 8.6±0.13µs ? ?/sec 1.00 8.6±0.31µs ? ?/sec
take str null values null indices 1024 1.00 6.3±0.13µs ? ?/sec 1.00 6.3±0.03µs ? ?/sec
take stringview 1024 1.00 860.4±23.03ns ? ?/sec 1.00 856.1±3.33ns ? ?/sec
take stringview 512 1.01 481.8±3.92ns ? ?/sec 1.00 475.2±4.21ns ? ?/sec
take stringview null indices 1024 1.00 1371.2±19.60ns ? ?/sec 1.01 1386.5±21.26ns ? ?/sec
take stringview null indices 512 1.00 695.1±5.88ns ? ?/sec 1.00 693.5±4.96ns ? ?/sec
take stringview null values 1024 1.01 2.1±0.04µs ? ?/sec 1.00 2.1±0.04µs ? ?/sec
take stringview null values null indices 1024 1.01 2.9±0.04µs ? ?/sec 1.00 2.8±0.03µs ? ?/sec
```
</p>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Take fsb null indices [arrow-rs]
Posted by "tobixdev (via GitHub)" <gi...@apache.org>.
tobixdev commented on code in PR #8981:
URL: https://github.com/apache/arrow-rs/pull/8981#discussion_r2609967966
##########
arrow-select/src/take.rs:
##########
Review Comment:
Maybe one note for this change. As I understand it, some take kernels are using `to_usize` while others are using `as_usize`. I've now used `as_usize` as it is also used in the `take_native` kernel.
Is there any guidelines on which operation we should use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Take fsb null indices [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #8981:
URL: https://github.com/apache/arrow-rs/pull/8981#issuecomment-3641869330
run bnechmark take_kernels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Take fsb null indices [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8981:
URL: https://github.com/apache/arrow-rs/pull/8981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Take fsb null indices [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #8981:
URL: https://github.com/apache/arrow-rs/pull/8981#issuecomment-3643388296
Thanks again @tobixdev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org