You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Vibhatha Lakmal Abeykoon (Jira)" <ji...@apache.org> on 2021/12/14 04:04:00 UTC
[jira] [Comment Edited] (ARROW-15019) [Python] Add bindings for new dataset writing options
[ https://issues.apache.org/jira/browse/ARROW-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458885#comment-17458885 ]
Vibhatha Lakmal Abeykoon edited comment on ARROW-15019 at 12/14/21, 4:03 AM:
-----------------------------------------------------------------------------
Also it seems `min_rows_per_group` and `max_rows_per_group` would be required to write these test cases. The C++ test case shows that. Without this parameter we may run into issues like
`pyarrow.lib.ArrowInvalid: max_rows_per_group must be less than or equal to max_rows_per_file{*}`{*}
CPP Test: https://github.com/apache/arrow/blob/cf8d81d9fcbc43ce57b8a0d36c05f8b4273a5fa3/cpp/src/arrow/dataset/dataset_writer_test.cc#L210
Should we add a separate PR to expose these attributes to Python or should we do within the same PR?
was (Author: vibhatha):
Also it seems `min_rows_per_group` and `max_rows_per_group` would be required to write these test cases. The C++ test case shows that. Without this parameter we may run into issues like
`pyarrow.lib.ArrowInvalid: max_rows_per_group must be less than or equal to max_rows_per_file{*}`{*}
Should we add a separate PR to expose these attributes to Python or should we do within the same PR?
> [Python] Add bindings for new dataset writing options
> -----------------------------------------------------
>
> Key: ARROW-15019
> URL: https://issues.apache.org/jira/browse/ARROW-15019
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Python
> Reporter: Vibhatha Lakmal Abeykoon
> Assignee: Vibhatha Lakmal Abeykoon
> Priority: Major
> Labels: dataset, pull-request-available
> Fix For: 7.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Added a subtask to separate the work on Python bindings
--
This message was sent by Atlassian Jira
(v8.20.1#820001)