You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/05/11 07:05:34 UTC
[GitHub] [incubator-pegasus] empiredan opened a new pull request, #1474: feat(new_metrics): migrate metrics for replica_stub (part 6)
empiredan opened a new pull request, #1474:
URL: https://github.com/apache/incubator-pegasus/pull/1474
https://github.com/apache/incubator-pegasus/issues/1454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1474: feat(new_metrics): migrate metrics for replica_stub (part 6)
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #1474:
URL: https://github.com/apache/incubator-pegasus/pull/1474#discussion_r1191195347
##########
src/replica/bulk_load/replica_bulk_loader.cpp:
##########
@@ -50,6 +48,41 @@
#include "utils/string_view.h"
#include "utils/thread_access_checker.h"
+METRIC_DEFINE_counter(replica,
+ bulk_load_download_count,
Review Comment:
OK. Actually in perf counter they are accumulative counter. We could observe their increase. We could also change them to gauge, by decreasing them while finished. Is this OK ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1474: feat(new_metrics): migrate metrics for replica_stub (part 6)
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1474:
URL: https://github.com/apache/incubator-pegasus/pull/1474#discussion_r1191164603
##########
src/replica/replica_stub.cpp:
##########
@@ -191,6 +191,21 @@ METRIC_DEFINE_counter(server,
dsn::metric_unit::kRequests,
"The number of busy write requests");
+METRIC_DEFINE_gauge_int64(server,
+ bulk_load_running_count,
+ dsn::metric_unit::kBulkLoads,
+ "The number of current running bulk loads");
+
+METRIC_DEFINE_gauge_int64(server,
Review Comment:
For the xxx_max_xxx mastrics, how about use percentile? we can do that in next patches.
##########
src/replica/bulk_load/replica_bulk_loader.cpp:
##########
@@ -50,6 +48,41 @@
#include "utils/string_view.h"
#include "utils/thread_access_checker.h"
+METRIC_DEFINE_counter(replica,
+ bulk_load_download_count,
Review Comment:
Like `bulk_load_running_count`, how about rename the following two metrics to `bulk_load_downloading_count` and `bulk_load_ingesting_count` ?
And in fact they are gauge type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1474: feat(new_metrics): migrate metrics for replica_stub (part 6)
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #1474:
URL: https://github.com/apache/incubator-pegasus/pull/1474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org