[GitHub] [accumulo] milleruntime commented on pull request #2601: Add exception to catch class loading error

[GitBox <gi...@apache.org>]

milleruntime commented on pull request #2601:
URL: https://github.com/apache/accumulo/pull/2601#issuecomment-1083419697


   I talked to @dlmarion a bit to try and figure out if we need this check or not. The problem I am having is there are parts of the code where we set useAccumuloClassLoader = true but context = null. The class loader code has a guard against context being null (since it is optional) and will default to returning the VFS loader. Table context is optional for users to set but internally this seems like a bug to me since we are expecting to use the "AccumuloClassLoader" to be returned but return the deprecated `AccumuloVFSClassLoader`. It could just be confusion over what exactly is the "AccumuloClassLoader".
   
   Here is the part that returns the class loader in ClassLoaderUtil:
   https://github.com/apache/accumulo/blob/68acf9f101efeaf3a612b39e898a3a58090470fa/core/src/main/java/org/apache/accumulo/core/classloader/ClassLoaderUtil.java#L75-L81


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org