You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/08 04:56:10 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8853: ARROW-10827: [Rust] Extended concat and made it faster (2-6x)

jorgecarleitao commented on a change in pull request #8853:
URL: https://github.com/apache/arrow/pull/8853#discussion_r538034958



##########
File path: rust/arrow/src/array/builder.rs
##########
@@ -3969,579 +3296,4 @@ mod tests {
         // Special error if the key overflows (256th entry)
         builder.append(1257).unwrap();
     }
-
-    #[test]
-    fn test_primitive_append() -> Result<()> {

Review comment:
       Yes, there is. PR's description:
   
   > I would like to migrate all the tests for the XBuilder::append_data to the MutableArrayData, to not lose them, but for that #8850 #8852 #8851 and #8849 and #8848 needs to land first (thus being a draft).
   
   ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org