You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/02 19:39:31 UTC
[GitHub] [incubator-superset] geido opened a new pull request #11899: refactor: Move Badge to Antdesign
geido opened a new pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899
### SUMMARY
Move the Badge component from react-bootstrap to Antdesign and add the ability to change text color.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TEST PLAN
1. Log into Superset
2. Navigate to Datasets
3. Edit a dataset
4. Look for the badges for METRICS, COLUMNS, and CALCULATED COLUMNS
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#discussion_r535864775
##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -751,24 +751,6 @@
@well-bg: @gray-bg; // superset-var
@well-border: darken(@well-bg, 7%);
-// == Badges
-//
-// ##
-
-@badge-color: @lightest; // superset-var
-// ** Linked badge text color on hover
-@badge-link-hover-color: @lightest; // superset-var
-@badge-bg: @brand-primary;
-
-// ** Badge text color in active nav link
-@badge-active-color: @link-color;
-// ** Badge background color in active nav link
-@badge-active-bg: @lightest; // superset-var
-
-@badge-font-weight: bold;
-@badge-line-height: 1;
-@badge-border-radius: 10px;
-
Review comment:
Ahh, good catch... I got too excited.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (a5fe406) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f2d9f0001302c548216b542867fa0ddf3ed483cc?el=desc) (f2d9f00) will **decrease** coverage by `12.68%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
===========================================
- Coverage 67.64% 54.96% -12.69%
===========================================
Files 927 421 -506
Lines 45011 14794 -30217
Branches 4308 3812 -496
===========================================
- Hits 30449 8131 -22318
+ Misses 14458 6663 -7795
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.96% <100.00%> (-0.04%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.88% <ø> (-0.31%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `53.30% <100.00%> (-20.29%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [776 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [f2d9f00...a5fe406](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (1a54c4d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/327a2817d35416f74902c889487d0aa6ff1969b8?el=desc) (327a281) will **decrease** coverage by `0.59%`.
> The diff coverage is `57.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 63.84% 63.25% -0.60%
==========================================
Files 930 931 +1
Lines 45174 45175 +1
Branches 4333 4335 +2
==========================================
- Hits 28842 28576 -266
- Misses 16155 16422 +267
Partials 177 177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.14% <57.89%> (-0.02%)` | :arrow_down: |
| python | `63.31% <ø> (-0.93%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-0.38%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <100.00%> (ø)` | |
| [...erset-frontend/src/profile/components/Security.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9TZWN1cml0eS50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [327a281...1a54c4d](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (1a54c4d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/327a2817d35416f74902c889487d0aa6ff1969b8?el=desc) (327a281) will **decrease** coverage by `0.13%`.
> The diff coverage is `57.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 63.84% 63.70% -0.14%
==========================================
Files 930 931 +1
Lines 45174 45190 +16
Branches 4333 4335 +2
==========================================
- Hits 28842 28789 -53
- Misses 16155 16224 +69
Partials 177 177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.14% <57.89%> (-0.02%)` | :arrow_down: |
| python | `64.03% <ø> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-0.38%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <100.00%> (ø)` | |
| [...erset-frontend/src/profile/components/Security.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9TZWN1cml0eS50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [327a281...1a54c4d](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] geido commented on a change in pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#discussion_r536173981
##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -751,24 +751,6 @@
@well-bg: @gray-bg; // superset-var
@well-border: darken(@well-bg, 7%);
-// == Badges
-//
-// ##
-
-@badge-color: @lightest; // superset-var
-// ** Linked badge text color on hover
-@badge-link-hover-color: @lightest; // superset-var
-@badge-bg: @brand-primary;
-
-// ** Badge text color in active nav link
-@badge-active-color: @link-color;
-// ** Badge background color in active nav link
-@badge-active-bg: @lightest; // superset-var
-
-@badge-font-weight: bold;
-@badge-line-height: 1;
-@badge-border-radius: 10px;
-
Review comment:
Restored. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#discussion_r535853325
##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -751,24 +751,6 @@
@well-bg: @gray-bg; // superset-var
@well-border: darken(@well-bg, 7%);
-// == Badges
-//
-// ##
-
-@badge-color: @lightest; // superset-var
-// ** Linked badge text color on hover
-@badge-link-hover-color: @lightest; // superset-var
-@badge-bg: @brand-primary;
-
-// ** Badge text color in active nav link
-@badge-active-color: @link-color;
-// ** Badge background color in active nav link
-@badge-active-bg: @lightest; // superset-var
-
-@badge-font-weight: bold;
-@badge-line-height: 1;
-@badge-border-radius: 10px;
-
Review comment:
I think it's ok to remove this, but generally I'd keep the theme intact for where FAB is used (the goal is to remove all of the FAB templates, but there are still some CRUD pages that are FAB-powered, and if they have a bootstrap badge they'll won't be themed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (c4a04f8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f2d9f0001302c548216b542867fa0ddf3ed483cc?el=desc) (f2d9f00) will **decrease** coverage by `4.33%`.
> The diff coverage is `57.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 67.64% 63.31% -4.34%
==========================================
Files 927 929 +2
Lines 45011 45061 +50
Branches 4308 4311 +3
==========================================
- Hits 30449 28530 -1919
- Misses 14458 16354 +1896
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.16% <57.89%> (-0.01%)` | :arrow_down: |
| python | `63.39% <ø> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-3.08%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <100.00%> (-6.50%)` | :arrow_down: |
| [...erset-frontend/src/profile/components/Security.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9TZWN1cml0eS50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [195 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [f2d9f00...c4a04f8](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (1a54c4d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/327a2817d35416f74902c889487d0aa6ff1969b8?el=desc) (327a281) will **decrease** coverage by `0.13%`.
> The diff coverage is `57.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 63.84% 63.71% -0.14%
==========================================
Files 930 931 +1
Lines 45174 45175 +1
Branches 4333 4335 +2
==========================================
- Hits 28842 28782 -60
- Misses 16155 16216 +61
Partials 177 177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.14% <57.89%> (-0.02%)` | :arrow_down: |
| python | `64.04% <ø> (-0.21%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-0.38%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <100.00%> (ø)` | |
| [...erset-frontend/src/profile/components/Security.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9TZWN1cml0eS50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [327a281...1a54c4d](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (c4a04f8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f2d9f0001302c548216b542867fa0ddf3ed483cc?el=desc) (f2d9f00) will **decrease** coverage by `4.29%`.
> The diff coverage is `57.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 67.64% 63.35% -4.30%
==========================================
Files 927 929 +2
Lines 45011 45061 +50
Branches 4308 4311 +3
==========================================
- Hits 30449 28547 -1902
- Misses 14458 16337 +1879
- Partials 104 177 +73
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `63.16% <57.89%> (-0.01%)` | :arrow_down: |
| python | `63.45% <ø> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-3.08%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <100.00%> (-6.50%)` | :arrow_down: |
| [...erset-frontend/src/profile/components/Security.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9TZWN1cml0eS50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [194 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [f2d9f00...c4a04f8](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (1a54c4d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/327a2817d35416f74902c889487d0aa6ff1969b8?el=desc) (327a281) will **decrease** coverage by `0.03%`.
> The diff coverage is `57.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 63.84% 63.80% -0.04%
==========================================
Files 930 931 +1
Lines 45174 45190 +16
Branches 4333 4335 +2
==========================================
- Hits 28842 28835 -7
- Misses 16155 16178 +23
Partials 177 177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.14% <57.89%> (-0.02%)` | :arrow_down: |
| python | `64.19% <ø> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-0.38%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <100.00%> (ø)` | |
| [...erset-frontend/src/profile/components/Security.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9TZWN1cml0eS50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [327a281...1a54c4d](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (c4a04f8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f2d9f0001302c548216b542867fa0ddf3ed483cc?el=desc) (f2d9f00) will **decrease** coverage by `4.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 67.64% 63.39% -4.25%
==========================================
Files 927 462 -465
Lines 45011 28418 -16593
Branches 4308 0 -4308
==========================================
- Hits 30449 18017 -12432
+ Misses 14458 10401 -4057
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.39% <ø> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [468 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [f2d9f00...c4a04f8](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#discussion_r535678963
##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -751,24 +751,6 @@
@well-bg: @gray-bg; // superset-var
@well-border: darken(@well-bg, 7%);
-// == Badges
-//
-// ##
-
-@badge-color: @lightest; // superset-var
-// ** Linked badge text color on hover
-@badge-link-hover-color: @lightest; // superset-var
-@badge-bg: @brand-primary;
-
-// ** Badge text color in active nav link
-@badge-active-color: @link-color;
-// ** Badge background color in active nav link
-@badge-active-bg: @lightest; // superset-var
-
-@badge-font-weight: bold;
-@badge-line-height: 1;
-@badge-border-radius: 10px;
-
Review comment:
OMG! So happy to see less LESS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (1a54c4d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/327a2817d35416f74902c889487d0aa6ff1969b8?el=desc) (327a281) will **decrease** coverage by `0.69%`.
> The diff coverage is `57.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 63.84% 63.14% -0.70%
==========================================
Files 930 469 -461
Lines 45174 16694 -28480
Branches 4333 4335 +2
==========================================
- Hits 28842 10542 -18300
+ Misses 16155 5975 -10180
Partials 177 177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.14% <57.89%> (-0.02%)` | :arrow_down: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-0.38%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <100.00%> (ø)` | |
| [...erset-frontend/src/profile/components/Security.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9TZWN1cml0eS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...dding\_unique\_constraint\_on\_dashboard\_slices\_tbl.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xOTAxODg5Mzg1ODJfYWRkaW5nX3VuaXF1ZV9jb25zdHJhaW50X29uX2Rhc2hib2FyZF9zbGljZXNfdGJsLnB5) | | |
| [superset/examples/unicode\_test\_data.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdW5pY29kZV90ZXN0X2RhdGEucHk=) | | |
| [...t/migrations/versions/e866bd2d4976\_smaller\_grid.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lODY2YmQyZDQ5NzZfc21hbGxlcl9ncmlkLnB5) | | |
| [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | | |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [327a281...1a54c4d](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (1a54c4d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/327a2817d35416f74902c889487d0aa6ff1969b8?el=desc) (327a281) will **decrease** coverage by `0.03%`.
> The diff coverage is `57.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 63.84% 63.80% -0.04%
==========================================
Files 930 931 +1
Lines 45174 45190 +16
Branches 4333 4335 +2
==========================================
- Hits 28842 28835 -7
- Misses 16155 16178 +23
Partials 177 177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.14% <57.89%> (-0.02%)` | :arrow_down: |
| python | `64.19% <ø> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-0.38%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <100.00%> (ø)` | |
| [...erset-frontend/src/profile/components/Security.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9TZWN1cml0eS50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.14% <0.00%> (-0.81%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.47%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [327a281...1a54c4d](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] geido commented on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737452789
@junlincc @rusackas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] geido commented on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-738844319
> Code LGTM, and I'm ready to approve on that, but the text in the badges looks just _slightly_ off-center, to the right. Have you looked at what might be causing that? The 1 looks good in the screenshot, the 4 looks a bit off (might be the optical weight of the shape of the number), but the 0 should look centered, I would think.
@rusackas Thanks for noticing. Should look better now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (c4a04f8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f2d9f0001302c548216b542867fa0ddf3ed483cc?el=desc) (f2d9f00) will **decrease** coverage by `4.23%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 67.64% 63.40% -4.24%
==========================================
Files 927 462 -465
Lines 45011 28403 -16608
Branches 4308 0 -4308
==========================================
- Hits 30449 18010 -12439
+ Misses 14458 10393 -4065
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.40% <ø> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.08% <0.00%> (-29.97%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [f2d9f00...c4a04f8](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-738351435
Code LGTM, and I'm ready to approve on that, but the text in the badges looks just _slightly_ off-center, to the right. Have you looked at what might be causing that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (a5fe406) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f2d9f0001302c548216b542867fa0ddf3ed483cc?el=desc) (f2d9f00) will **decrease** coverage by `13.27%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
===========================================
- Coverage 67.64% 54.37% -13.28%
===========================================
Files 927 421 -506
Lines 45011 14794 -30217
Branches 4308 3812 -496
===========================================
- Hits 30449 8044 -22405
+ Misses 14458 6750 -7708
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.37% <100.00%> (-0.63%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-3.08%)` | :arrow_down: |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `53.30% <100.00%> (-20.29%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [777 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [f2d9f00...a5fe406](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-737491984
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=h1) Report
> Merging [#11899](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=desc) (1a54c4d) into [master](https://codecov.io/gh/apache/incubator-superset/commit/327a2817d35416f74902c889487d0aa6ff1969b8?el=desc) (327a281) will **decrease** coverage by `0.16%`.
> The diff coverage is `57.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11899 +/- ##
==========================================
- Coverage 63.84% 63.67% -0.17%
==========================================
Files 930 931 +1
Lines 45174 45175 +1
Branches 4333 4335 +2
==========================================
- Hits 28842 28766 -76
- Misses 16155 16232 +77
Partials 177 177
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.14% <57.89%> (-0.02%)` | :arrow_down: |
| python | `63.98% <ø> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <ø> (-0.38%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/common/components/Badge.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0JhZGdlLnRzeA==) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <100.00%> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `67.09% <100.00%> (ø)` | |
| [...erset-frontend/src/profile/components/Security.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9TZWN1cml0eS50c3g=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/11899/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=footer). Last update [327a281...1a54c4d](https://codecov.io/gh/apache/incubator-superset/pull/11899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas edited a comment on pull request #11899: refactor: Move Badge to Antdesign
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #11899:
URL: https://github.com/apache/incubator-superset/pull/11899#issuecomment-738351435
Code LGTM, and I'm ready to approve on that, but the text in the badges looks just _slightly_ off-center, to the right. Have you looked at what might be causing that? The 1 looks good in the screenshot, the 4 looks a bit off (might be the optical weight of the shape of the number), but the 0 should look centered, I would think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org