[jira] [Commented] (GEODE-2936) Refactor OrderByComparator's compare method to reduce redundant code

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049500#comment-16049500 ] 

ASF GitHub Bot commented on GEODE-2936:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/580

    GEODE-2936: Refactoring OrderByComparator

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-2936)
    
    `OrderByComparator.java` contained a lot of redundant and confusing code, as well as somewhat misleading comments (for example, the `compare` method was supposed to throw a `ClassCastException` if the parameters given could not be compared using this comparator, but it didn't. This has been fixed). Code that is shared by both the `compare` and `evaluateSortCriteria` methods has been moved to helper methods to improve readability and reduce redundancy.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-2936-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #580
    
----
commit 3ff6d0a2b4f097947e337f5567b641aeadfb0e22
Author: Jinmei Liao <ji...@pivotal.io>
Date:   2017-06-07T23:10:56Z

    GEODE-2936: Refactoring OrderByComparator to reduce redundant code and improve readability.

----


> Refactor OrderByComparator's compare method to reduce redundant code
> --------------------------------------------------------------------
>
>                 Key: GEODE-2936
>                 URL: https://issues.apache.org/jira/browse/GEODE-2936
>             Project: Geode
>          Issue Type: Bug
>          Components: querying
>            Reporter: nabarun
>            Assignee: Emily Yeh
>
> Issue:
> OrderByComparator's compare method has a lot of redundant code.
> Solution:
> These code sections can be modified to have one method call



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)