[jira] Updated: (HADOOP-6521) FsPermission:SetUMask not updated to use new-style umask setting.

["Suresh Srinivas (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-6521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas updated HADOOP-6521:
------------------------------------

    Attachment: hadoop-6521.patch

Changes in the patch:
# Symbolic and octal umask mode was added configurable with param name "dfs.umaskmode". It deprecates the old param "dfs.umask". Previously for backward compatibility new deprecation mechanism introduced in 0.21 was used. This mechanism is useful when a config param name changes, to map the old config name to the new. However in case of umask, the semantics of the param also changes. Old param expects decimal value and the new param  expects symbolic or octal value. The deprecation mechanism in addition to mapping old to new names, must also translated the old value to new value. Given the lack of this capability, umask will no longer use config deprecation mechanism.

# Following changes from 0.20 version of the patch is carried forward, with the exception of test changes. Test changes are needed in HDFS. I will created a separate jira for that.
{quote}
    1.  To ensure backward compatibility, when applications use the old key "dfs.umask" and the server default has "dfs.umaskmode", old key overrides the new key. That is first the old key is used for getting umask and then the new key.
   2. FsPermission.setUMask(Configuration conf, FsPermission umask) currently has a bug. When setting the "dfs.umaskmode" param in the configuration, it should convert the umask decimal value to octal.
{quote}


> FsPermission:SetUMask not updated to use new-style umask setting.
> -----------------------------------------------------------------
>
>                 Key: HADOOP-6521
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6521
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Jakob Homan
>            Assignee: Suresh Srinivas
>         Attachments: hadoop-6521.patch, hadoop-6521.rel20.1.patch, hadoop-6521.rel20.patch, hadoop-6521.rel20.patch, hadoop-6521.rel20.patch
>
>
> FsPermission:
> {code}
> 221   /** Set the user file creation mask (umask) */
> 222   public static void setUMask(Configuration conf, FsPermission umask) {                                    
> 223     conf.setInt(UMASK_LABEL, umask.toShort());
> 224   }
> {code}
> Needs to be updated to not use a decimal value. This is a bug introduced by HADOOP-6234.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira