You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2023/11/23 06:49:48 UTC

[Impala-ASF-CR] IMPALA-12465: Unicode column name support

pranav.lodha@cloudera.com has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/20506 )

Change subject: IMPALA-12465: Unicode column name support
......................................................................

IMPALA-12465: Unicode column name support

Impala depends on Hive functions for column name
validation and uses validateName() function for the same.
Since Hive already supports unicode column names,
the patch just updates the column name validation function
to validateColumnName(). validateName() checks for a certain
conformance based on pattern matching standards while
validateColumnName() places no restrictions on column names
at the Metadata level.
This is just a primitive patch which will need a lot of testing
and enhancements as we proceed.

Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718
---
M fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java
M testdata/datasets/functional/functional_schema_template.sql
A testdata/workloads/functional-query/queries/QueryTest/create-table-unicode.test
M testdata/workloads/functional-query/queries/QueryTest/create-table.test
A tests/metadata/column-unicode.py
M tests/shell/test_shell_interactive.py
8 files changed, 404 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/20506/5
-- 
To view, visit http://gerrit.cloudera.org:8080/20506
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718
Gerrit-Change-Number: 20506
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>