You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Bernd Fondermann <bf...@brainlounge.de> on 2009/05/16 22:52:16 UTC
[vysper] Pubsub code organization
Hi,
For the pubsub module, I'd propose to
+ move the 'general' and 'owner' package to 'handler', or,
alternatively, move the handler classes they contain to two new
'handler' sub-packages respectively.
+ rename test case classes to *TestCase or *Test so they are clearly
identifyable as such by their name. If you use a view where all classes
from one package are shown together even if they are on different dirs,
this would be a big help.
WDYT?
Bernd
Re: [vysper] Pubsub code organization
Posted by Michael Jakl <ja...@gmail.com>.
Hi!
On Sun, May 17, 2009 at 21:30, Bernd Fondermann <bf...@brainlounge.de> wrote:
> Michael Jakl wrote:
> If you don't have too much pending work which is not stored anywhere
> else, I recommend removing the bad dirs and then do svn update.
svn up (--force) didn't bring back my dirs. I had to checkout an older
revision and update to HEAD. At least I didn't need to wipe it (again
;)).
Cheers,
Michael
Re: [vysper] Pubsub code organization
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Michael Jakl wrote:
> Hi!
>
> On Sun, May 17, 2009 at 20:14, Bernd Fondermann
> <be...@googlemail.com> wrote:
>> r775668+9 contain changes equivalent to your patch. please check and
>> report problems. maybe you need to revert your local changes to
>> continue your work.
>
> Thanks for the notice, unfortunately I've already messed up my working
> copy (real bad).
If you don't have too much pending work which is not stored anywhere
else, I recommend removing the bad dirs and then do svn update.
Bernd
Re: [vysper] Pubsub code organization
Posted by Michael Jakl <ja...@gmail.com>.
Hi!
On Sun, May 17, 2009 at 20:14, Bernd Fondermann
<be...@googlemail.com> wrote:
> r775668+9 contain changes equivalent to your patch. please check and
> report problems. maybe you need to revert your local changes to
> continue your work.
Thanks for the notice, unfortunately I've already messed up my working
copy (real bad).
Michael
Re: [vysper] Pubsub code organization
Posted by Bernd Fondermann <be...@googlemail.com>.
On Sat, May 16, 2009 at 23:09, Michael Jakl <ja...@gmail.com> wrote:
> Hi!
>
> On Sat, May 16, 2009 at 23:07, Bernd Fondermann <bf...@brainlounge.de> wrote:
>> Michael Jakl wrote:
>> I can do it, if this proves to be too cumbersome to do in a patch.
>
> Done already. But Eclipse (Subversion?) doesn't recognize renamings
> and move operations so the patch is quite large :(
r775668+9 contain changes equivalent to your patch. please check and
report problems. maybe you need to revert your local changes to
continue your work.
Bernd
Re: [vysper] Pubsub code organization
Posted by Michael Jakl <ja...@gmail.com>.
Hi!
On Sat, May 16, 2009 at 23:07, Bernd Fondermann <bf...@brainlounge.de> wrote:
> Michael Jakl wrote:
> I can do it, if this proves to be too cumbersome to do in a patch.
Done already. But Eclipse (Subversion?) doesn't recognize renamings
and move operations so the patch is quite large :(
Cheers,
Michael
Re: [vysper] Pubsub code organization
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Michael Jakl wrote:
> Hi!
>
> On Sat, May 16, 2009 at 22:52, Bernd Fondermann <bf...@brainlounge.de> wrote:
>> For the pubsub module, I'd propose to
>>
>> + move the 'general' and 'owner' package to 'handler', or,
>> alternatively, move the handler classes they contain to two new
>> 'handler' sub-packages respectively.
>
> +1, I wasn't happy with "general" anyways. What about .handler for the
> current "general" package and .handler.owner for the #owner namespace?
+1
I can do it, if this proves to be too cumbersome to do in a patch.
>> + rename test case classes to *TestCase or *Test so they are clearly
>> identifyable as such by their name. If you use a view where all classes
>> from one package are shown together even if they are on different dirs,
>> this would be a big help.
>
> +1, the ant task will also profit from the "right" naming.
Great, thanks.
Bernd
Re: [vysper] Pubsub code organization
Posted by Michael Jakl <ja...@gmail.com>.
Hi!
On Sat, May 16, 2009 at 22:52, Bernd Fondermann <bf...@brainlounge.de> wrote:
> For the pubsub module, I'd propose to
>
> + move the 'general' and 'owner' package to 'handler', or,
> alternatively, move the handler classes they contain to two new
> 'handler' sub-packages respectively.
+1, I wasn't happy with "general" anyways. What about .handler for the
current "general" package and .handler.owner for the #owner namespace?
> + rename test case classes to *TestCase or *Test so they are clearly
> identifyable as such by their name. If you use a view where all classes
> from one package are shown together even if they are on different dirs,
> this would be a big help.
+1, the ant task will also profit from the "right" naming.
Cheers,
Michael