You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hanisha Koneru (JIRA)" <ji...@apache.org> on 2018/07/02 23:12:00 UTC
[jira] [Commented] (HDDS-205) Add metrics to HddsDispatcher
[ https://issues.apache.org/jira/browse/HDDS-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530557#comment-16530557 ]
Hanisha Koneru commented on HDDS-205:
-------------------------------------
Thanks [~bharatviswa] for working on this.
Patch LGTM overall. Just a couple of comments:
# KeyValueHandler - Line 363 - Typo, should be PutKey instead of GetKey.
# In handleWriteChunk, metrics.incContainerBytesStats should only be done when the chunk is in WRITE_DATA and COMBINED. For COMMIT_DATA, we are not actually writing any data.
> Add metrics to HddsDispatcher
> -----------------------------
>
> Key: HDDS-205
> URL: https://issues.apache.org/jira/browse/HDDS-205
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-205-HDDS-48.00.patch, HDDS-205-HDDS-48.01.patch, HDDS-205-HDDS-48.02.patch
>
>
> This patch adds metrics to newly added HddsDispatcher.
> This uses, already existing ContainerMetrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org