You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/19 16:51:38 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #19371: Refactor ConvertYamlConfigurationHandler
RaigorJiang opened a new pull request, #19371:
URL: https://github.com/apache/shardingsphere/pull/19371
Revise #19280.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19371: Refactor ConvertYamlConfigurationHandler
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19371:
URL: https://github.com/apache/shardingsphere/pull/19371#issuecomment-1189720624
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19371](https://codecov.io/gh/apache/shardingsphere/pull/19371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f742138) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b292bd62198ac3904ad93e4d01ae01790c65d1c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b292bd6) will **decrease** coverage by `0.00%`.
> The diff coverage is `6.77%`.
```diff
@@ Coverage Diff @@
## master #19371 +/- ##
============================================
- Coverage 59.62% 59.61% -0.01%
Complexity 2373 2373
============================================
Files 3818 3819 +1
Lines 54370 54382 +12
Branches 7626 7628 +2
============================================
+ Hits 32418 32420 +2
- Misses 19154 19162 +8
- Partials 2798 2800 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...t/distsql/parser/segment/EncryptColumnSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/19371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC1kaXN0c3FsLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9zZWdtZW50L0VuY3J5cHRDb2x1bW5TZWdtZW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...lgorithm/keygen/SnowflakeKeyGenerateAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/19371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL2tleWdlbi9Tbm93Zmxha2VLZXlHZW5lcmF0ZUFsZ29yaXRobS5qYXZh) | `88.46% <0.00%> (ø)` | |
| [...ql/ral/common/constant/DistSQLScriptConstants.java](https://codecov.io/gh/apache/shardingsphere/pull/19371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9jb25zdGFudC9EaXN0U1FMU2NyaXB0Q29uc3RhbnRzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ral/queryable/ConvertYamlConfigurationHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/19371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9Db252ZXJ0WWFtbENvbmZpZ3VyYXRpb25IYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ndler/converter/EncryptRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/19371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZGlzdHNxbC9oYW5kbGVyL2NvbnZlcnRlci9FbmNyeXB0UnVsZVN0YXRlbWVudENvbnZlcnRlci5qYXZh) | `88.88% <60.00%> (-7.12%)` | :arrow_down: |
| [...stsql/handler/query/EncryptRuleQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/19371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L0VuY3J5cHRSdWxlUXVlcnlSZXN1bHRTZXQuamF2YQ==) | `78.26% <100.00%> (-0.91%)` | :arrow_down: |
| [...nd/text/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/19371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #19371: Refactor ConvertYamlConfigurationHandler
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #19371:
URL: https://github.com/apache/shardingsphere/pull/19371#discussion_r925110662
##########
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/queryable/ConvertYamlConfigurationHandler.java:
##########
@@ -67,61 +64,75 @@ protected Collection<LocalDataQueryResultRow> getRows(final ContextManager conte
} catch (final IOException ex) {
throw new ShardingSphereException(ex);
}
- String convertedDistSQL = generateConvertedDistSQL(yamlConfig);
- return Collections.singleton(new LocalDataQueryResultRow(convertedDistSQL));
+ Preconditions.checkNotNull(yamlConfig, String.format("Invalid yaml file `%s`", file.getName()));
Review Comment:
OK, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #19371: Refactor ConvertYamlConfigurationHandler
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #19371:
URL: https://github.com/apache/shardingsphere/pull/19371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #19371: Refactor ConvertYamlConfigurationHandler
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #19371:
URL: https://github.com/apache/shardingsphere/pull/19371#discussion_r925104825
##########
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/queryable/ConvertYamlConfigurationHandler.java:
##########
@@ -67,61 +64,75 @@ protected Collection<LocalDataQueryResultRow> getRows(final ContextManager conte
} catch (final IOException ex) {
throw new ShardingSphereException(ex);
}
- String convertedDistSQL = generateConvertedDistSQL(yamlConfig);
- return Collections.singleton(new LocalDataQueryResultRow(convertedDistSQL));
+ Preconditions.checkNotNull(yamlConfig, String.format("Invalid yaml file `%s`", file.getName()));
Review Comment:
Consider replacing String.format with Preconditions' method with template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org